You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by GitBox <gi...@apache.org> on 2022/06/30 02:32:51 UTC
[GitHub] [incubator-shenyu-client-golang] lishuo5263 opened a new pull request, #19: [Refactor: design sdk_client_interface & rename zk_client.]
lishuo5263 opened a new pull request, #19:
URL: https://github.com/apache/incubator-shenyu-client-golang/pull/19
* Design sdk_client_interface
* rename zk_client
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu-client-golang] yu199195 commented on a diff in pull request #19: [Refactor: design sdk_client_interface & rename zk_client.]
Posted by GitBox <gi...@apache.org>.
yu199195 commented on code in PR #19:
URL: https://github.com/apache/incubator-shenyu-client-golang/pull/19#discussion_r910558241
##########
README_CN.md:
##########
@@ -2,6 +2,7 @@
English | [简体中文](README_CN.md)
+[](https://www.oscs1024.com/project/apache/incubator-shenyu-client-golang?ref=badge_small)
Review Comment:
remove this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu-client-golang] lishuo5263 commented on a diff in pull request #19: [Refactor: design sdk_client_interface & rename zk_client.]
Posted by GitBox <gi...@apache.org>.
lishuo5263 commented on code in PR #19:
URL: https://github.com/apache/incubator-shenyu-client-golang/pull/19#discussion_r910561948
##########
README.md:
##########
@@ -2,6 +2,7 @@
English | [简体中文](README_CN.md)
+[](https://www.oscs1024.com/project/apache/incubator-shenyu-client-golang?ref=badge_small)
Review Comment:
it been removed
##########
README_CN.md:
##########
@@ -2,6 +2,7 @@
English | [简体中文](README_CN.md)
+[](https://www.oscs1024.com/project/apache/incubator-shenyu-client-golang?ref=badge_small)
Review Comment:
it been removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu-client-golang] codecov-commenter commented on pull request #19: [Refactor: design sdk_client_interface & rename zk_client.]
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #19:
URL: https://github.com/apache/incubator-shenyu-client-golang/pull/19#issuecomment-1170682576
# [Codecov](https://codecov.io/gh/apache/incubator-shenyu-client-golang/pull/19?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19](https://codecov.io/gh/apache/incubator-shenyu-client-golang/pull/19?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (eef963e) into [main](https://codecov.io/gh/apache/incubator-shenyu-client-golang/commit/c4e7abfd28077c1b92592fb1ce0c0f65b3103c33?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c4e7abf) will **decrease** coverage by `15.76%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## main #19 +/- ##
===========================================
- Coverage 31.01% 15.25% -15.77%
===========================================
Files 7 7
Lines 216 177 -39
===========================================
- Hits 67 27 -40
- Misses 131 148 +17
+ Partials 18 2 -16
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu-client-golang/pull/19?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [clients/zk\_client/zk\_client.go](https://codecov.io/gh/apache/incubator-shenyu-client-golang/pull/19/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50cy96a19jbGllbnQvemtfY2xpZW50Lmdv) | | |
| [example/zk\_client/main.go](https://codecov.io/gh/apache/incubator-shenyu-client-golang/pull/19/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXhhbXBsZS96a19jbGllbnQvbWFpbi5nbw==) | `0.00% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu-client-golang/pull/19?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu-client-golang/pull/19?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c4e7abf...eef963e](https://codecov.io/gh/apache/incubator-shenyu-client-golang/pull/19?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu-client-golang] yu199195 merged pull request #19: [Refactor: design sdk_client_interface & rename zk_client.]
Posted by GitBox <gi...@apache.org>.
yu199195 merged PR #19:
URL: https://github.com/apache/incubator-shenyu-client-golang/pull/19
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org