[GitHub] flink pull request #3640: [FLINK-6213] [yarn] terminate resource manager its...

[tillrohrmann <gi...@git.apache.org>]

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3640#discussion_r130309444
  
    --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/YarnFlinkResourceManager.java ---
    @@ -300,6 +301,8 @@ protected void shutdownApplication(ApplicationStatus finalStatus, String optiona
     		} catch (Throwable t) {
     			LOG.error("Could not cleanly shut down the Node Manager Client", t);
     		}
    +
    +		self().tell(decorateMessage(PoisonPill.getInstance()), self());
    --- End diff --
    
    I would directly call `getContext().system().stop(self())`, because that way we will stop immediately processing any further messages.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---