You are viewing a plain text version of this content. The canonical link for it is here.
Posted to c-dev@xerces.apache.org by GitBox <gi...@apache.org> on 2021/08/18 16:19:27 UTC
[GitHub] [xerces-c] rouault opened a new pull request #28: CurlURLInputStream constructor: avoid memory leak
rouault opened a new pull request #28:
URL: https://github.com/apache/xerces-c/pull/28
CurlURLInputStream constructor calls the readMore() method, which can
throw exceptions. In that situation, the destructor is not called, which
results in resource/memory leaks. To fix that, catch the exceptions,
manually do the cleanup and rethrow the exceptions.
Found by ossfuzz (locally)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: c-dev-unsubscribe@xerces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: c-dev-unsubscribe@xerces.apache.org
For additional commands, e-mail: c-dev-help@xerces.apache.org
[GitHub] [xerces-c] rouault commented on pull request #28: CurlURLInputStream constructor: avoid memory leak
Posted by GitBox <gi...@apache.org>.
rouault commented on pull request #28:
URL: https://github.com/apache/xerces-c/pull/28#issuecomment-901396666
> Have you signed the Apache CLA for Xerces-C contributions?
Ah I missed that was necessary... I've just done that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: c-dev-unsubscribe@xerces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: c-dev-unsubscribe@xerces.apache.org
For additional commands, e-mail: c-dev-help@xerces.apache.org
[GitHub] [xerces-c] rleigh-codelibre commented on pull request #28: CurlURLInputStream constructor: avoid memory leak
Posted by GitBox <gi...@apache.org>.
rleigh-codelibre commented on pull request #28:
URL: https://github.com/apache/xerces-c/pull/28#issuecomment-901377686
This looks fine to me.
Have you signed the Apache CLA for Xerces-C contributions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: c-dev-unsubscribe@xerces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: c-dev-unsubscribe@xerces.apache.org
For additional commands, e-mail: c-dev-help@xerces.apache.org
[GitHub] [xerces-c] rleigh-codelibre merged pull request #28: XERCESC-2218: CurlURLInputStream constructor: avoid memory leak
Posted by GitBox <gi...@apache.org>.
rleigh-codelibre merged pull request #28:
URL: https://github.com/apache/xerces-c/pull/28
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: c-dev-unsubscribe@xerces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: c-dev-unsubscribe@xerces.apache.org
For additional commands, e-mail: c-dev-help@xerces.apache.org
[GitHub] [xerces-c] rleigh-codelibre commented on pull request #28: CurlURLInputStream constructor: avoid memory leak
Posted by GitBox <gi...@apache.org>.
rleigh-codelibre commented on pull request #28:
URL: https://github.com/apache/xerces-c/pull/28#issuecomment-901398016
Many thanks for that; we'll be able to merge everything once that's gone through.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: c-dev-unsubscribe@xerces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: c-dev-unsubscribe@xerces.apache.org
For additional commands, e-mail: c-dev-help@xerces.apache.org