You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/11/01 01:43:48 UTC

[GitHub] [apisix] tzssangglass commented on pull request #8205: feat: add request body to google-cloud-logging

tzssangglass commented on PR #8205:
URL: https://github.com/apache/apisix/pull/8205#issuecomment-1297903541

   > I think i've got the correct test added here now however i'm having trouble to get the tests working locally. Is it possible to get the CI enabled to verify the tests are correct?
   
   When you fix the comments, I will perform CI manually first (github restricts the user who submits for the first time to be confirmed by the maintainer before performing CI)
   
   Your test case does not cover the function you added, you can refer to: https://github.com/apache/apisix/blob/024e0ef70b5e403e11eb7a2f4abb59675a657081/t/plugin/http-logger2.t#L212-L262
   
   condition: `"include_req_body": true` --> 
   
   verify:
   `--- error_log
   request.body:test-http-logger-request` 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org