You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2021/05/14 15:44:06 UTC
[kudu-CR] [hms] Allow the table type to change but not the synchronization of a table
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17445
Change subject: [hms] Allow the table type to change but not the synchronization of a table
......................................................................
[hms] Allow the table type to change but not the synchronization of a table
When upgrading some verions of the Hive Metastore it migrates Kudu tables
from managed tables to external tables with the purge property set. Both
of these states are considered “synchronized” tables by the HMS sync
and therefore this change sholuld be allowed as it won’t created orphaned
tables.
Change-Id: I7c029da1dbfef9812b0fe7389a768772605acc45
---
M java/kudu-hive/src/main/java/org/apache/kudu/hive/metastore/KuduMetastorePlugin.java
M java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java
2 files changed, 34 insertions(+), 22 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/45/17445/1
--
To view, visit http://gerrit.cloudera.org:8080/17445
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7c029da1dbfef9812b0fe7389a768772605acc45
Gerrit-Change-Number: 17445
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR] [hms] Allow the table type to change but not the synchronization of a table
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has removed a vote on this change.
Change subject: [hms] Allow the table type to change but not the synchronization of a table
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/17445
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I7c029da1dbfef9812b0fe7389a768772605acc45
Gerrit-Change-Number: 17445
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [hms] Allow the table type to change but not the synchronization of a table
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17445 )
Change subject: [hms] Allow the table type to change but not the synchronization of a table
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/17445
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7c029da1dbfef9812b0fe7389a768772605acc45
Gerrit-Change-Number: 17445
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 14 May 2021 15:55:00 +0000
Gerrit-HasComments: No
[kudu-CR] [hms] Allow the table type to change but not the synchronization of a table
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/17445 )
Change subject: [hms] Allow the table type to change but not the synchronization of a table
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/17445
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7c029da1dbfef9812b0fe7389a768772605acc45
Gerrit-Change-Number: 17445
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 14 May 2021 16:28:51 +0000
Gerrit-HasComments: No
[kudu-CR] [hms] Allow the table type to change but not the synchronization of a table
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17445 )
Change subject: [hms] Allow the table type to change but not the synchronization of a table
......................................................................
[hms] Allow the table type to change but not the synchronization of a table
When upgrading some verions of the Hive Metastore it migrates Kudu tables
from managed tables to external tables with the purge property set. Both
of these states are considered “synchronized” tables by the HMS sync
and therefore this change sholuld be allowed as it won’t created orphaned
tables.
Change-Id: I7c029da1dbfef9812b0fe7389a768772605acc45
Reviewed-on: http://gerrit.cloudera.org:8080/17445
Reviewed-by: Attila Bukor <ab...@apache.org>
Tested-by: Grant Henke <gr...@apache.org>
---
M java/kudu-hive/src/main/java/org/apache/kudu/hive/metastore/KuduMetastorePlugin.java
M java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java
2 files changed, 34 insertions(+), 22 deletions(-)
Approvals:
Attila Bukor: Looks good to me, approved
Grant Henke: Verified
--
To view, visit http://gerrit.cloudera.org:8080/17445
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I7c029da1dbfef9812b0fe7389a768772605acc45
Gerrit-Change-Number: 17445
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)