You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2020/01/10 15:18:49 UTC
[GitHub] [zookeeper] belugabehr opened a new pull request #1216:
ZOOKEEPER-3688: Use StandardCharsets UTF-8 in Jute toString
belugabehr opened a new pull request #1216: ZOOKEEPER-3688: Use StandardCharsets UTF-8 in Jute toString
URL: https://github.com/apache/zookeeper/pull/1216
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zookeeper] maoling commented on a change in pull request #1216:
ZOOKEEPER-3688: Use StandardCharsets UTF-8 in Jute toString
Posted by GitBox <gi...@apache.org>.
maoling commented on a change in pull request #1216: ZOOKEEPER-3688: Use StandardCharsets UTF-8 in Jute toString
URL: https://github.com/apache/zookeeper/pull/1216#discussion_r365637503
##########
File path: zookeeper-jute/src/main/java/org/apache/jute/compiler/JRecord.java
##########
@@ -497,7 +497,7 @@ public void genJavaCode(File outputDirectory) throws IOException {
jj.write(jf.genJavaWriteMethodName());
}
jj.write(" a_.endRecord(this,\"\");\n");
- jj.write(" return new String(s.toByteArray(), \"UTF-8\");\n");
+ jj.write(" return new String(s.toByteArray(), java.nio.charset.StandardCharsets.UTF_8);\n");
jj.write(" } catch (Throwable ex) {\n");
jj.write(" ex.printStackTrace();\n");
Review comment:
+1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zookeeper] belugabehr commented on issue #1216: ZOOKEEPER-3688:
Use StandardCharsets UTF-8 in Jute toString
Posted by GitBox <gi...@apache.org>.
belugabehr commented on issue #1216: ZOOKEEPER-3688: Use StandardCharsets UTF-8 in Jute toString
URL: https://github.com/apache/zookeeper/pull/1216#issuecomment-577199920
@anmolnar Good for 3.7?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services