You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by "Howard M. Lewis Ship (JIRA)" <ta...@jakarta.apache.org> on 2005/11/23 19:25:36 UTC

[jira] Created: (TAPESTRY-773) Excess code generate for required parameters

Excess code generate for required parameters
--------------------------------------------

         Key: TAPESTRY-773
         URL: http://issues.apache.org/jira/browse/TAPESTRY-773
     Project: Tapestry
        Type: Bug
  Components: Framework  
    Versions: 4.0    
    Reporter: Howard M. Lewis Ship
    Priority: Minor


When Tapestry is generating code to support component parameters, it generates code such as the following for the setter method:

public void setRefresh(org.apache.tapestry.IActionListener $1)
{
  if (! isInActiveState())
  {
    _$refresh$Default = $1;
    return;
  }
  org.apache.tapestry.IBinding binding = getBinding("refresh");
  if (binding == null)
    throw new org.apache.hivemind.ApplicationRuntimeException("Parameter 'refresh' is not bound and can not be updated.");
  binding.setObject(($w) $1);
  if (isRendering())
  {
    _$refresh = $1;
    _$refresh$Cached = true;
  }
}


The binding == null check in the middle should be omitted for required parameters, which will always be bound. This will save (a tiny amount of) processing time when generating this code.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: tapestry-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tapestry-dev-help@jakarta.apache.org


[jira] Updated: (TAPESTRY-773) Excess code generate for required parameters

Posted by "Jesse Kuhnert (JIRA)" <ta...@jakarta.apache.org>.
     [ http://issues.apache.org/jira/browse/TAPESTRY-773?page=all ]

Jesse Kuhnert updated TAPESTRY-773:
-----------------------------------

    Fix Version/s: 4.1.2

> Excess code generate for required parameters
> --------------------------------------------
>
>                 Key: TAPESTRY-773
>                 URL: http://issues.apache.org/jira/browse/TAPESTRY-773
>             Project: Tapestry
>          Issue Type: Improvement
>          Components: Framework
>    Affects Versions: 4.0
>            Reporter: Howard M. Lewis Ship
>            Priority: Minor
>             Fix For: 4.1.2
>
>
> When Tapestry is generating code to support component parameters, it generates code such as the following for the setter method:
> public void setRefresh(org.apache.tapestry.IActionListener $1)
> {
>   if (! isInActiveState())
>   {
>     _$refresh$Default = $1;
>     return;
>   }
>   org.apache.tapestry.IBinding binding = getBinding("refresh");
>   if (binding == null)
>     throw new org.apache.hivemind.ApplicationRuntimeException("Parameter 'refresh' is not bound and can not be updated.");
>   binding.setObject(($w) $1);
>   if (isRendering())
>   {
>     _$refresh = $1;
>     _$refresh$Cached = true;
>   }
> }
> The binding == null check in the middle should be omitted for required parameters, which will always be bound. This will save (a tiny amount of) processing time when generating this code.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


[jira] Updated: (TAPESTRY-773) Excess code generate for required parameters

Posted by "Andreas Andreou (JIRA)" <ta...@jakarta.apache.org>.
     [ http://issues.apache.org/jira/browse/TAPESTRY-773?page=all ]

Andreas Andreou updated TAPESTRY-773:
-------------------------------------

    Issue Type: Improvement  (was: Bug)

> Excess code generate for required parameters
> --------------------------------------------
>
>                 Key: TAPESTRY-773
>                 URL: http://issues.apache.org/jira/browse/TAPESTRY-773
>             Project: Tapestry
>          Issue Type: Improvement
>          Components: Framework
>    Affects Versions: 4.0
>            Reporter: Howard M. Lewis Ship
>            Priority: Minor
>
> When Tapestry is generating code to support component parameters, it generates code such as the following for the setter method:
> public void setRefresh(org.apache.tapestry.IActionListener $1)
> {
>   if (! isInActiveState())
>   {
>     _$refresh$Default = $1;
>     return;
>   }
>   org.apache.tapestry.IBinding binding = getBinding("refresh");
>   if (binding == null)
>     throw new org.apache.hivemind.ApplicationRuntimeException("Parameter 'refresh' is not bound and can not be updated.");
>   binding.setObject(($w) $1);
>   if (isRendering())
>   {
>     _$refresh = $1;
>     _$refresh$Cached = true;
>   }
> }
> The binding == null check in the middle should be omitted for required parameters, which will always be bound. This will save (a tiny amount of) processing time when generating this code.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


[jira] Updated: (TAPESTRY-773) Excess code generate for required parameters

Posted by "Jesse Kuhnert (JIRA)" <de...@tapestry.apache.org>.
     [ https://issues.apache.org/jira/browse/TAPESTRY-773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jesse Kuhnert updated TAPESTRY-773:
-----------------------------------

    Fix Version/s:     (was: 4.1.3)
                   4.1.4

> Excess code generate for required parameters
> --------------------------------------------
>
>                 Key: TAPESTRY-773
>                 URL: https://issues.apache.org/jira/browse/TAPESTRY-773
>             Project: Tapestry
>          Issue Type: Improvement
>          Components: Framework
>    Affects Versions: 4.0
>            Reporter: Howard M. Lewis Ship
>            Priority: Minor
>             Fix For: 4.1.4
>
>
> When Tapestry is generating code to support component parameters, it generates code such as the following for the setter method:
> public void setRefresh(org.apache.tapestry.IActionListener $1)
> {
>   if (! isInActiveState())
>   {
>     _$refresh$Default = $1;
>     return;
>   }
>   org.apache.tapestry.IBinding binding = getBinding("refresh");
>   if (binding == null)
>     throw new org.apache.hivemind.ApplicationRuntimeException("Parameter 'refresh' is not bound and can not be updated.");
>   binding.setObject(($w) $1);
>   if (isRendering())
>   {
>     _$refresh = $1;
>     _$refresh$Cached = true;
>   }
> }
> The binding == null check in the middle should be omitted for required parameters, which will always be bound. This will save (a tiny amount of) processing time when generating this code.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


[jira] Updated: (TAPESTRY-773) Excess code generate for required parameters

Posted by "Marcus Schulte (JIRA)" <de...@tapestry.apache.org>.
     [ https://issues.apache.org/jira/browse/TAPESTRY-773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marcus Schulte updated TAPESTRY-773:
------------------------------------

    Fix Version/s:     (was: 4.1.6)
                   4.1.7

> Excess code generate for required parameters
> --------------------------------------------
>
>                 Key: TAPESTRY-773
>                 URL: https://issues.apache.org/jira/browse/TAPESTRY-773
>             Project: Tapestry
>          Issue Type: Improvement
>          Components: Framework
>    Affects Versions: 4.0
>            Reporter: Howard M. Lewis Ship
>            Priority: Minor
>             Fix For: 4.1.7
>
>
> When Tapestry is generating code to support component parameters, it generates code such as the following for the setter method:
> public void setRefresh(org.apache.tapestry.IActionListener $1)
> {
>   if (! isInActiveState())
>   {
>     _$refresh$Default = $1;
>     return;
>   }
>   org.apache.tapestry.IBinding binding = getBinding("refresh");
>   if (binding == null)
>     throw new org.apache.hivemind.ApplicationRuntimeException("Parameter 'refresh' is not bound and can not be updated.");
>   binding.setObject(($w) $1);
>   if (isRendering())
>   {
>     _$refresh = $1;
>     _$refresh$Cached = true;
>   }
> }
> The binding == null check in the middle should be omitted for required parameters, which will always be bound. This will save (a tiny amount of) processing time when generating this code.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


[jira] Updated: (TAPESTRY-773) Excess code generate for required parameters

Posted by "Jesse Kuhnert (JIRA)" <de...@tapestry.apache.org>.
     [ https://issues.apache.org/jira/browse/TAPESTRY-773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jesse Kuhnert updated TAPESTRY-773:
-----------------------------------

    Fix Version/s:     (was: 4.1.5)
                   4.1.6

> Excess code generate for required parameters
> --------------------------------------------
>
>                 Key: TAPESTRY-773
>                 URL: https://issues.apache.org/jira/browse/TAPESTRY-773
>             Project: Tapestry
>          Issue Type: Improvement
>          Components: Framework
>    Affects Versions: 4.0
>            Reporter: Howard M. Lewis Ship
>            Priority: Minor
>             Fix For: 4.1.6
>
>
> When Tapestry is generating code to support component parameters, it generates code such as the following for the setter method:
> public void setRefresh(org.apache.tapestry.IActionListener $1)
> {
>   if (! isInActiveState())
>   {
>     _$refresh$Default = $1;
>     return;
>   }
>   org.apache.tapestry.IBinding binding = getBinding("refresh");
>   if (binding == null)
>     throw new org.apache.hivemind.ApplicationRuntimeException("Parameter 'refresh' is not bound and can not be updated.");
>   binding.setObject(($w) $1);
>   if (isRendering())
>   {
>     _$refresh = $1;
>     _$refresh$Cached = true;
>   }
> }
> The binding == null check in the middle should be omitted for required parameters, which will always be bound. This will save (a tiny amount of) processing time when generating this code.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


[jira] Updated: (TAPESTRY-773) Excess code generate for required parameters

Posted by "Jesse Kuhnert (JIRA)" <de...@tapestry.apache.org>.
     [ https://issues.apache.org/jira/browse/TAPESTRY-773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jesse Kuhnert updated TAPESTRY-773:
-----------------------------------

    Fix Version/s:     (was: 4.1.2)
                   4.1.3

> Excess code generate for required parameters
> --------------------------------------------
>
>                 Key: TAPESTRY-773
>                 URL: https://issues.apache.org/jira/browse/TAPESTRY-773
>             Project: Tapestry
>          Issue Type: Improvement
>          Components: Framework
>    Affects Versions: 4.0
>            Reporter: Howard M. Lewis Ship
>            Priority: Minor
>             Fix For: 4.1.3
>
>
> When Tapestry is generating code to support component parameters, it generates code such as the following for the setter method:
> public void setRefresh(org.apache.tapestry.IActionListener $1)
> {
>   if (! isInActiveState())
>   {
>     _$refresh$Default = $1;
>     return;
>   }
>   org.apache.tapestry.IBinding binding = getBinding("refresh");
>   if (binding == null)
>     throw new org.apache.hivemind.ApplicationRuntimeException("Parameter 'refresh' is not bound and can not be updated.");
>   binding.setObject(($w) $1);
>   if (isRendering())
>   {
>     _$refresh = $1;
>     _$refresh$Cached = true;
>   }
> }
> The binding == null check in the middle should be omitted for required parameters, which will always be bound. This will save (a tiny amount of) processing time when generating this code.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org