You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2016/12/04 21:18:01 UTC
Review Request 54350: Added a DUP2 child hook to Subprocess.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54350/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Kevin Klues.
Bugs: MESOS-6470
https://issues.apache.org/jira/browse/MESOS-6470
Repository: mesos
Description
-------
Added a DUP2 child hook to Subprocess.
Diffs
-----
3rdparty/libprocess/include/process/subprocess_base.hpp 1d02454d5541f96cb4928bf027fcae3764989d67
3rdparty/libprocess/src/subprocess.cpp 284e22e28ae8d2c1486e4a6bea743b8663ce2023
Diff: https://reviews.apache.org/r/54350/diff/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 54350: Added a DUP2 child hook to Subprocess.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54350/#review157952
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Hindman
On Dec. 4, 2016, 9:18 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54350/
> -----------------------------------------------------------
>
> (Updated Dec. 4, 2016, 9:18 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Kevin Klues.
>
>
> Bugs: MESOS-6470
> https://issues.apache.org/jira/browse/MESOS-6470
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a DUP2 child hook to Subprocess.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/subprocess_base.hpp 1d02454d5541f96cb4928bf027fcae3764989d67
> 3rdparty/libprocess/src/subprocess.cpp 284e22e28ae8d2c1486e4a6bea743b8663ce2023
>
> Diff: https://reviews.apache.org/r/54350/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 54350: Added a DUP2 child hook to Subprocess.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54350/
-----------------------------------------------------------
(Updated Dec. 5, 2016, 5:36 a.m.)
Review request for mesos, Benjamin Hindman and Kevin Klues.
Changes
-------
Rebased.
Bugs: MESOS-6470
https://issues.apache.org/jira/browse/MESOS-6470
Repository: mesos
Description
-------
Added a DUP2 child hook to Subprocess.
Diffs (updated)
-----
3rdparty/libprocess/include/process/subprocess_base.hpp 1d02454d5541f96cb4928bf027fcae3764989d67
3rdparty/libprocess/src/subprocess.cpp 284e22e28ae8d2c1486e4a6bea743b8663ce2023
Diff: https://reviews.apache.org/r/54350/diff/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 54350: Added a DUP2 child hook to Subprocess.
Posted by Kevin Klues <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54350/#review157935
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Klues
On Dec. 4, 2016, 9:18 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54350/
> -----------------------------------------------------------
>
> (Updated Dec. 4, 2016, 9:18 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Kevin Klues.
>
>
> Bugs: MESOS-6470
> https://issues.apache.org/jira/browse/MESOS-6470
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a DUP2 child hook to Subprocess.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/subprocess_base.hpp 1d02454d5541f96cb4928bf027fcae3764989d67
> 3rdparty/libprocess/src/subprocess.cpp 284e22e28ae8d2c1486e4a6bea743b8663ce2023
>
> Diff: https://reviews.apache.org/r/54350/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>