[jira] [Commented] (HBASE-12521) Bring down number of checkstyle warnings

["Sean Busbey (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-12521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14216704#comment-14216704 ] 

Sean Busbey commented on HBASE-12521:
-------------------------------------

To help with prioritizing, this is our current break down

{code}
grep -o -e "source=\".*\"" /tmp/trunkCheckstyle.xml  | sort | uniq -c | sort -n -r
1591 source="com.puppycrawl.tools.checkstyle.checks.design.VisibilityModifierCheck"
 915 source="com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck"
 316 source="com.puppycrawl.tools.checkstyle.checks.imports.UnusedImportsCheck"
 168 source="com.puppycrawl.tools.checkstyle.checks.whitespace.ParenPadCheck"
 147 source="com.puppycrawl.tools.checkstyle.checks.annotation.MissingDeprecatedCheck"
 103 source="com.puppycrawl.tools.checkstyle.checks.design.HideUtilityClassConstructorCheck"
  83 source="com.puppycrawl.tools.checkstyle.checks.blocks.EmptyBlockCheck"
  70 source="com.puppycrawl.tools.checkstyle.checks.whitespace.MethodParamPadCheck"
  61 source="com.puppycrawl.tools.checkstyle.checks.UpperEllCheck"
  53 source="com.puppycrawl.tools.checkstyle.checks.coding.InnerAssignmentCheck"
  53 source="com.puppycrawl.tools.checkstyle.checks.ArrayTypeStyleCheck"
  52 source="com.puppycrawl.tools.checkstyle.checks.design.FinalClassCheck"
  42 source="com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck"
  37 source="com.puppycrawl.tools.checkstyle.checks.sizes.MethodLengthCheck"
  29 source="com.puppycrawl.tools.checkstyle.checks.coding.MissingSwitchDefaultCheck"
  28 source="com.puppycrawl.tools.checkstyle.checks.imports.AvoidStarImportCheck"
  16 source="com.puppycrawl.tools.checkstyle.checks.imports.RedundantImportCheck"
   9 source="com.puppycrawl.tools.checkstyle.checks.coding.EqualsHashCodeCheck"
   8 source="com.puppycrawl.tools.checkstyle.checks.coding.EmptyStatementCheck"
   5 source="com.puppycrawl.tools.checkstyle.checks.design.InterfaceIsTypeCheck"
   1 source="com.puppycrawl.tools.checkstyle.checks.coding.NoFinalizerCheck"
   1 source="com.puppycrawl.tools.checkstyle.TreeWalker"
{code}

> Bring down number of checkstyle warnings
> ----------------------------------------
>
>                 Key: HBASE-12521
>                 URL: https://issues.apache.org/jira/browse/HBASE-12521
>             Project: HBase
>          Issue Type: Task
>            Reporter: Sean Busbey
>            Assignee: Sean Busbey
>            Priority: Minor
>              Labels: checkstyle
>
> I should have made this umbrella task to begin with. We currently have thousands of checkstyle warnings, making it cumbersome for new users to look for their own.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)