You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@arrow.apache.org by "Rok Mihevc (Jira)" <ji...@apache.org> on 2021/03/01 17:08:00 UTC
[jira] [Commented] (ARROW-10405) [C++] IsIn kernel should be able
to lookup dictionary in string
[ https://issues.apache.org/jira/browse/ARROW-10405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17293030#comment-17293030 ]
Rok Mihevc commented on ARROW-10405:
------------------------------------
[~westonpace] indeed just removing pre-dispatch checks works. I'm not sure how that would be performance wise so I'm adding another pre-check for now.
> [C++] IsIn kernel should be able to lookup dictionary in string
> ---------------------------------------------------------------
>
> Key: ARROW-10405
> URL: https://issues.apache.org/jira/browse/ARROW-10405
> Project: Apache Arrow
> Issue Type: Bug
> Components: C++
> Reporter: Neal Richardson
> Assignee: Rok Mihevc
> Priority: Major
> Labels: pull-request-available
> Fix For: 4.0.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Repro in R:
> {code}
> > a1 <- Array$create(c("A", "B", "C"))
> > a2 <- Array$create(as.factor(c("A", "B", "C")))
> > a1
> Array
> <string>
> [
> "A",
> "B",
> "C"
> ]
> > a2
> DictionaryArray
> <dictionary<values=string, indices=int8>>
> -- dictionary:
> [
> "A",
> "B",
> "C"
> ]
> -- indices:
> [
> 0,
> 1,
> 2
> ]
> > arrow:::call_function("is_in_meta_binary", a1, Array$create("B"))
> <pointer: 0x5575885e9070>
> > arrow:::call_function("is_in_meta_binary", a2, Array$create("B"))
> Error in compute__CallFunction(function_name, args, options) :
> Invalid: Array type didn't match type of values set: dictionary<values=string, indices=int8, ordered=0> vs string
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)