[jira] [Commented] (FLINK-10000) There's a mistake in the comments of CoGroupedStreams.java

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-10000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16616222#comment-16616222 ] 

ASF GitHub Bot commented on FLINK-10000:
----------------------------------------

Clarkkkkk closed pull request #6463: [FLINK-10000][streaming]Fix the example of CoGroupedStreams
URL: https://github.com/apache/flink/pull/6463
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/CoGroupedStreams.java b/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/CoGroupedStreams.java
index 55009e1b4cb..24ff1e71413 100644
--- a/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/CoGroupedStreams.java
+++ b/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/CoGroupedStreams.java
@@ -68,7 +68,7 @@
  *
  * DataStream<T> result = one.coGroup(two)
  *     .where(new MyFirstKeySelector())
- *     .equalTo(new MyFirstKeySelector())
+ *     .equalTo(new MySecondKeySelector())
  *     .window(TumblingEventTimeWindows.of(Time.of(5, TimeUnit.SECONDS)))
  *     .apply(new MyCoGroupFunction());
  * } </pre>


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> There's a mistake in the comments of CoGroupedStreams.java
> ----------------------------------------------------------
>
>                 Key: FLINK-10000
>                 URL: https://issues.apache.org/jira/browse/FLINK-10000
>             Project: Flink
>          Issue Type: Improvement
>          Components: DataStream API
>            Reporter: Shimin Yang
>            Assignee: Shimin Yang
>            Priority: Minor
>              Labels: pull-request-available
>
> The example of {{CoGroupedStream}}
> {code}
>     DataStream<T> result = one.coGroup(two)
>       .where(new MyFirstKeySelector())
>       .equalTo(new MyFirstKeySelector())
>       .window(TumblingEventTimeWindows.of(Time.of(5, TimeUnit.SECONDS)))
>       .apply(new MyCoGroupFunction());
>  {code}
> the params of method {{equalTo}} should be {{MySecondKeySelector}} instead of {{MyFirstKeySelector}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)