You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by gaborhermann <gi...@git.apache.org> on 2015/02/23 14:10:57 UTC
[GitHub] flink pull request: [FLINK-1553] [streaming] Reworked Kafka connec...
GitHub user gaborhermann opened a pull request:
https://github.com/apache/flink/pull/433
[FLINK-1553] [streaming] Reworked Kafka connectors
I refactored the Kafka connectors. It works parallelly: output gets distributed between Kafka partitions by default, and users can also add a custom partitioning function.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mbalassi/flink kafka-connector
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/433.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #433
----
commit bf92467c9c7644f3b6294cffc76b1c6d129cc77f
Author: Gábor Hermann <re...@gmail.com>
Date: 2015-02-20T17:10:21Z
[FLINK-1553] [streaming] Reworked Kafka connectors
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-1553] [streaming] Reworked Kafka connec...
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/433#issuecomment-75919869
Well, the code does not compile: https://travis-ci.org/apache/flink/jobs/51825098
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-1553] [streaming] Reworked Kafka connec...
Posted by gaborhermann <gi...@git.apache.org>.
Github user gaborhermann commented on the pull request:
https://github.com/apache/flink/pull/433#issuecomment-75928922
Sorry, I accidentally used a class only available in Java 8, and did not wait for the Travis build.
I fixed it. Travis still fails, but on an unrelated issue (see https://travis-ci.org/apache/flink/jobs/52101969).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-1553] [streaming] Reworked Kafka connec...
Posted by mbalassi <gi...@git.apache.org>.
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/433#issuecomment-75916547
LGTM at first view. Could you please update the documentation accordingly?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-1553] [streaming] Reworked Kafka connec...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/433
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---