You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2016/04/12 15:06:13 UTC
Review Request 46085: Added authentication to agent's
/monitor/statistics endpoint.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46085/
-----------------------------------------------------------
Review request for mesos, Adam B, Alexander Rojas, and Joerg Schad.
Bugs: MESOS-5152
https://issues.apache.org/jira/browse/MESOS-5152
Repository: mesos
Description
-------
Added authentication to agent's /monitor/statistics endpoint.
Diffs
-----
src/slave/http.cpp a684ff504535e2b9b2064f8048f5e03a0efcb059
src/slave/slave.hpp 76f3aff394e5cecc54dcb3065cb872e238bc228e
src/slave/slave.cpp f090c853b8affc4be5eecb4f616ec881fc2b60c3
src/tests/slave_tests.cpp 4a576b98d1cc58072626ac2c41c599bd3c8385c5
Diff: https://reviews.apache.org/r/46085/diff/
Testing
-------
make check (clang w/o optimization, OS X)
Additionally confirmed with an actual test cluster setup.
Thanks,
Benjamin Bannier
Re: Review Request 46085: Added authentication to agent's
/monitor/statistics endpoint.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46085/#review128467
-----------------------------------------------------------
Bad patch!
Reviews applied: [46085, 46084, 46083]
Failed command: ./support/apply-review.sh -n -r 46085
Error:
2016-04-12 16:55:45 URL:https://reviews.apache.org/r/46085/diff/raw/ [4804/4804] -> "46085.patch" [1]
error: patch failed: src/slave/slave.cpp:742
error: src/slave/slave.cpp: patch does not apply
Full log: https://builds.apache.org/job/mesos-reviewbot/12484/console
- Mesos ReviewBot
On April 12, 2016, 1:06 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46085/
> -----------------------------------------------------------
>
> (Updated April 12, 2016, 1:06 p.m.)
>
>
> Review request for mesos, Adam B, Alexander Rojas, and Joerg Schad.
>
>
> Bugs: MESOS-5152
> https://issues.apache.org/jira/browse/MESOS-5152
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added authentication to agent's /monitor/statistics endpoint.
>
>
> Diffs
> -----
>
> src/slave/http.cpp a684ff504535e2b9b2064f8048f5e03a0efcb059
> src/slave/slave.hpp 76f3aff394e5cecc54dcb3065cb872e238bc228e
> src/slave/slave.cpp f090c853b8affc4be5eecb4f616ec881fc2b60c3
> src/tests/slave_tests.cpp 4a576b98d1cc58072626ac2c41c599bd3c8385c5
>
> Diff: https://reviews.apache.org/r/46085/diff/
>
>
> Testing
> -------
>
> make check (clang w/o optimization, OS X)
>
> Additionally confirmed with an actual test cluster setup.
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 46085: Added authentication to agent's
/monitor/statistics endpoint.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46085/#review128604
-----------------------------------------------------------
Patch looks great!
Reviews applied: [46083, 46084, 46085]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On April 12, 2016, 8:04 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46085/
> -----------------------------------------------------------
>
> (Updated April 12, 2016, 8:04 p.m.)
>
>
> Review request for mesos, Adam B, Alexander Rojas, and Joerg Schad.
>
>
> Bugs: MESOS-5152
> https://issues.apache.org/jira/browse/MESOS-5152
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added authentication to agent's /monitor/statistics endpoint.
>
>
> Diffs
> -----
>
> src/slave/http.cpp a684ff504535e2b9b2064f8048f5e03a0efcb059
> src/slave/slave.hpp 76f3aff394e5cecc54dcb3065cb872e238bc228e
> src/slave/slave.cpp f3913c07b20fc759bbddb85921388e4c64cb49d9
> src/tests/slave_tests.cpp 4a576b98d1cc58072626ac2c41c599bd3c8385c5
>
> Diff: https://reviews.apache.org/r/46085/diff/
>
>
> Testing
> -------
>
> make check (clang w/o optimization, OS X)
>
> Additionally confirmed with an actual test cluster setup.
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 46085: Added authentication to agent's
/monitor/statistics endpoint.
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46085/#review128871
-----------------------------------------------------------
Ship it!
Ship It!
- Adam B
On April 12, 2016, 1:04 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46085/
> -----------------------------------------------------------
>
> (Updated April 12, 2016, 1:04 p.m.)
>
>
> Review request for mesos, Adam B, Alexander Rojas, and Joerg Schad.
>
>
> Bugs: MESOS-5152
> https://issues.apache.org/jira/browse/MESOS-5152
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added authentication to agent's /monitor/statistics endpoint.
>
>
> Diffs
> -----
>
> src/slave/http.cpp a684ff504535e2b9b2064f8048f5e03a0efcb059
> src/slave/slave.hpp 76f3aff394e5cecc54dcb3065cb872e238bc228e
> src/slave/slave.cpp f3913c07b20fc759bbddb85921388e4c64cb49d9
> src/tests/slave_tests.cpp 4a576b98d1cc58072626ac2c41c599bd3c8385c5
>
> Diff: https://reviews.apache.org/r/46085/diff/
>
>
> Testing
> -------
>
> make check (clang w/o optimization, OS X)
>
> Additionally confirmed with an actual test cluster setup.
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 46085: Added authentication to agent's
/monitor/statistics endpoint.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46085/
-----------------------------------------------------------
(Updated April 12, 2016, 10:04 p.m.)
Review request for mesos, Adam B, Alexander Rojas, and Joerg Schad.
Changes
-------
Rebased.
Bugs: MESOS-5152
https://issues.apache.org/jira/browse/MESOS-5152
Repository: mesos
Description
-------
Added authentication to agent's /monitor/statistics endpoint.
Diffs (updated)
-----
src/slave/http.cpp a684ff504535e2b9b2064f8048f5e03a0efcb059
src/slave/slave.hpp 76f3aff394e5cecc54dcb3065cb872e238bc228e
src/slave/slave.cpp f3913c07b20fc759bbddb85921388e4c64cb49d9
src/tests/slave_tests.cpp 4a576b98d1cc58072626ac2c41c599bd3c8385c5
Diff: https://reviews.apache.org/r/46085/diff/
Testing
-------
make check (clang w/o optimization, OS X)
Additionally confirmed with an actual test cluster setup.
Thanks,
Benjamin Bannier
Re: Review Request 46085: Added authentication to agent's
/monitor/statistics endpoint.
Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46085/#review128391
-----------------------------------------------------------
src/tests/slave_tests.cpp (line 1843)
<https://reviews.apache.org/r/46085/#comment191826>
As the .json endpoint is deprecated, I am not sure whether we need to tests those...
But just my opinion
- Joerg Schad
On April 12, 2016, 1:06 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46085/
> -----------------------------------------------------------
>
> (Updated April 12, 2016, 1:06 p.m.)
>
>
> Review request for mesos, Adam B, Alexander Rojas, and Joerg Schad.
>
>
> Bugs: MESOS-5152
> https://issues.apache.org/jira/browse/MESOS-5152
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added authentication to agent's /monitor/statistics endpoint.
>
>
> Diffs
> -----
>
> src/slave/http.cpp a684ff504535e2b9b2064f8048f5e03a0efcb059
> src/slave/slave.hpp 76f3aff394e5cecc54dcb3065cb872e238bc228e
> src/slave/slave.cpp f090c853b8affc4be5eecb4f616ec881fc2b60c3
> src/tests/slave_tests.cpp 4a576b98d1cc58072626ac2c41c599bd3c8385c5
>
> Diff: https://reviews.apache.org/r/46085/diff/
>
>
> Testing
> -------
>
> make check (clang w/o optimization, OS X)
>
> Additionally confirmed with an actual test cluster setup.
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 46085: Added authentication to agent's
/monitor/statistics endpoint.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46085/#review128402
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Rojas
On April 12, 2016, 3:06 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46085/
> -----------------------------------------------------------
>
> (Updated April 12, 2016, 3:06 p.m.)
>
>
> Review request for mesos, Adam B, Alexander Rojas, and Joerg Schad.
>
>
> Bugs: MESOS-5152
> https://issues.apache.org/jira/browse/MESOS-5152
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added authentication to agent's /monitor/statistics endpoint.
>
>
> Diffs
> -----
>
> src/slave/http.cpp a684ff504535e2b9b2064f8048f5e03a0efcb059
> src/slave/slave.hpp 76f3aff394e5cecc54dcb3065cb872e238bc228e
> src/slave/slave.cpp f090c853b8affc4be5eecb4f616ec881fc2b60c3
> src/tests/slave_tests.cpp 4a576b98d1cc58072626ac2c41c599bd3c8385c5
>
> Diff: https://reviews.apache.org/r/46085/diff/
>
>
> Testing
> -------
>
> make check (clang w/o optimization, OS X)
>
> Additionally confirmed with an actual test cluster setup.
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 46085: Added authentication to agent's
/monitor/statistics endpoint.
Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46085/#review128394
-----------------------------------------------------------
Ship it!
Ship It!
- Joerg Schad
On April 12, 2016, 1:06 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46085/
> -----------------------------------------------------------
>
> (Updated April 12, 2016, 1:06 p.m.)
>
>
> Review request for mesos, Adam B, Alexander Rojas, and Joerg Schad.
>
>
> Bugs: MESOS-5152
> https://issues.apache.org/jira/browse/MESOS-5152
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added authentication to agent's /monitor/statistics endpoint.
>
>
> Diffs
> -----
>
> src/slave/http.cpp a684ff504535e2b9b2064f8048f5e03a0efcb059
> src/slave/slave.hpp 76f3aff394e5cecc54dcb3065cb872e238bc228e
> src/slave/slave.cpp f090c853b8affc4be5eecb4f616ec881fc2b60c3
> src/tests/slave_tests.cpp 4a576b98d1cc58072626ac2c41c599bd3c8385c5
>
> Diff: https://reviews.apache.org/r/46085/diff/
>
>
> Testing
> -------
>
> make check (clang w/o optimization, OS X)
>
> Additionally confirmed with an actual test cluster setup.
>
>
> Thanks,
>
> Benjamin Bannier
>
>