You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2018/11/23 16:39:47 UTC
[GitHub] andrzej-kaczmarek opened a new pull request #1531: sys/stats: Fix
build error due to circular #include
andrzej-kaczmarek opened a new pull request #1531: sys/stats: Fix build error due to circular #include
URL: https://github.com/apache/mynewt-core/pull/1531
There's possible cicrular #include in stats.h which makes build fail:
something.c -> stats/stats.h
stats/stats.h -> os/mynewt.h
os/mynewt.h with NEWT_FEATURE_LOGCFG -> logcfg/logcfg.h
non-empty logcfg/logcfg.h -> modlog/modlog.h
modlog/modlog.h -> log/log.h
log/log.h with LOG_STATS uses stats macros and tries to include stats.h
properly, but since it's implicitly included from stats.h these macros
are not yet defined thus there are a lot of build errors in different
files.
The solution is to include os/os.h since this is what stats.h really
needs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services