You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/12/20 02:32:11 UTC
[GitHub] [doris] yixiutt opened a new pull request, #15190: [enhancement](compaction) add delete_sign_index check before filter delete
yixiutt opened a new pull request, #15190:
URL: https://github.com/apache/doris/pull/15190
# Proposed changes
Issue Number: close #xxx
## Problem summary
Describe your changes.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #15190: [enhancement](compaction) add delete_sign_index check before filter delete
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #15190:
URL: https://github.com/apache/doris/pull/15190#issuecomment-1360799162
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.97 seconds
load time: 427 seconds
storage size: 17123356954 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221221031236_clickbench_pr_65895.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] liaoxin01 commented on a diff in pull request #15190: [enhancement](compaction) add delete_sign_index check before filter delete
Posted by GitBox <gi...@apache.org>.
liaoxin01 commented on code in PR #15190:
URL: https://github.com/apache/doris/pull/15190#discussion_r1052849701
##########
be/src/vec/olap/block_reader.cpp:
##########
@@ -280,6 +280,11 @@ Status BlockReader::_unique_key_next_block(Block* block, MemPool* mem_pool, Obje
if (_filter_delete) {
int delete_sign_idx = _reader_context.tablet_schema->field_index(DELETE_SIGN);
DCHECK(delete_sign_idx > 0);
+ if (delete_sign_idx <= 0 || delete_sign_idx >= target_columns.size()) {
Review Comment:
delete line 282 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15190: [enhancement](compaction) add delete_sign_index check before filter delete
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15190:
URL: https://github.com/apache/doris/pull/15190#issuecomment-1360731882
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15190: [enhancement](compaction) add delete_sign_index check before filter delete
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15190:
URL: https://github.com/apache/doris/pull/15190#issuecomment-1358760256
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman merged pull request #15190: [enhancement](compaction) add delete_sign_index check before filter delete
Posted by GitBox <gi...@apache.org>.
morningman merged PR #15190:
URL: https://github.com/apache/doris/pull/15190
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yixiutt commented on a diff in pull request #15190: [enhancement](compaction) add delete_sign_index check before filter delete
Posted by GitBox <gi...@apache.org>.
yixiutt commented on code in PR #15190:
URL: https://github.com/apache/doris/pull/15190#discussion_r1052852883
##########
be/src/vec/olap/block_reader.cpp:
##########
@@ -280,6 +280,11 @@ Status BlockReader::_unique_key_next_block(Block* block, MemPool* mem_pool, Obje
if (_filter_delete) {
int delete_sign_idx = _reader_context.tablet_schema->field_index(DELETE_SIGN);
DCHECK(delete_sign_idx > 0);
+ if (delete_sign_idx <= 0 || delete_sign_idx >= target_columns.size()) {
Review Comment:
maybe we can find some bug with asan use DCEHCK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org