You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by sailaja mada <sa...@citrix.com> on 2013/07/17 20:10:05 UTC

Re: Review Request 12700: Fix for CLOUDSTACK-3596 to include domain id

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12700/
-----------------------------------------------------------

(Updated July 17, 2013, 6:10 p.m.)


Review request for cloudstack and Prasanna Santhanam.


Bugs: CLOUDSTACK-3596


Repository: cloudstack-git


Description
-------

Deploy VM request is sent without providing the Domain id . Cloudstack mandates to provide domain id along with account name.

Fix is to include domain id to resolve script failure (Execute cmd: deployvirtualmachine failed, due to: errorCode: 431, errorText:Account must be specified with domainId parameter)


Diffs
-----

  test/integration/component/test_accounts.py 65c0c6f 

Diff: https://reviews.apache.org/r/12700/diff/


Testing
-------

Tested with the change. Now test is passed.


Thanks,

sailaja mada

Re: Review Request 12700: Fix for CLOUDSTACK-3596 to include domain id

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12700/#review23377
-----------------------------------------------------------


Commit 3385b200faa929d2027c5e4743e58271f4d7ad56 in branch refs/heads/4.2 from sailajam
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=3385b20 ]

CLOUDSTACK-3596: Domain ID missing to deploy VM request . Included Domain id
(cherry picked from commit f5bd253b2b8d50bb42ce8a85b4d1db5b8e729b41)


- ASF Subversion and Git Services


On July 17, 2013, 6:10 p.m., sailaja mada wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12700/
> -----------------------------------------------------------
> 
> (Updated July 17, 2013, 6:10 p.m.)
> 
> 
> Review request for cloudstack and Prasanna Santhanam.
> 
> 
> Bugs: CLOUDSTACK-3596
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Deploy VM request is sent without providing the Domain id . Cloudstack mandates to provide domain id along with account name.
> 
> Fix is to include domain id to resolve script failure (Execute cmd: deployvirtualmachine failed, due to: errorCode: 431, errorText:Account must be specified with domainId parameter)
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_accounts.py 65c0c6f 
> 
> Diff: https://reviews.apache.org/r/12700/diff/
> 
> 
> Testing
> -------
> 
> Tested with the change. Now test is passed.
> 
> 
> Thanks,
> 
> sailaja mada
> 
>

Re: Review Request 12700: Fix for CLOUDSTACK-3596 to include domain id

Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12700/#review23353
-----------------------------------------------------------

Ship it!


LGTM. You don't have to go through reviewboard once you are a committer. please commit this.

- Prasanna Santhanam


On July 17, 2013, 6:10 p.m., sailaja mada wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12700/
> -----------------------------------------------------------
> 
> (Updated July 17, 2013, 6:10 p.m.)
> 
> 
> Review request for cloudstack and Prasanna Santhanam.
> 
> 
> Bugs: CLOUDSTACK-3596
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Deploy VM request is sent without providing the Domain id . Cloudstack mandates to provide domain id along with account name.
> 
> Fix is to include domain id to resolve script failure (Execute cmd: deployvirtualmachine failed, due to: errorCode: 431, errorText:Account must be specified with domainId parameter)
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_accounts.py 65c0c6f 
> 
> Diff: https://reviews.apache.org/r/12700/diff/
> 
> 
> Testing
> -------
> 
> Tested with the change. Now test is passed.
> 
> 
> Thanks,
> 
> sailaja mada
> 
>

Re: Review Request 12700: Fix for CLOUDSTACK-3596 to include domain id

Posted by Prasanna Santhanam <ts...@apache.org>.

> On July 18, 2013, 8:31 a.m., ASF Subversion and Git Services wrote:
> > Commit f5bd253b2b8d50bb42ce8a85b4d1db5b8e729b41 in branch refs/heads/master from sailajam
> > [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=f5bd253 ]
> > 
> > CLOUDSTACK-3596: Domain ID missing to deploy VM request . Included Domain id
> >

thanks. submitted this


- Prasanna


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12700/#review23357
-----------------------------------------------------------


On July 17, 2013, 6:10 p.m., sailaja mada wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12700/
> -----------------------------------------------------------
> 
> (Updated July 17, 2013, 6:10 p.m.)
> 
> 
> Review request for cloudstack and Prasanna Santhanam.
> 
> 
> Bugs: CLOUDSTACK-3596
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Deploy VM request is sent without providing the Domain id . Cloudstack mandates to provide domain id along with account name.
> 
> Fix is to include domain id to resolve script failure (Execute cmd: deployvirtualmachine failed, due to: errorCode: 431, errorText:Account must be specified with domainId parameter)
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_accounts.py 65c0c6f 
> 
> Diff: https://reviews.apache.org/r/12700/diff/
> 
> 
> Testing
> -------
> 
> Tested with the change. Now test is passed.
> 
> 
> Thanks,
> 
> sailaja mada
> 
>

Re: Review Request 12700: Fix for CLOUDSTACK-3596 to include domain id

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12700/#review23357
-----------------------------------------------------------


Commit f5bd253b2b8d50bb42ce8a85b4d1db5b8e729b41 in branch refs/heads/master from sailajam
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=f5bd253 ]

CLOUDSTACK-3596: Domain ID missing to deploy VM request . Included Domain id


- ASF Subversion and Git Services


On July 17, 2013, 6:10 p.m., sailaja mada wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12700/
> -----------------------------------------------------------
> 
> (Updated July 17, 2013, 6:10 p.m.)
> 
> 
> Review request for cloudstack and Prasanna Santhanam.
> 
> 
> Bugs: CLOUDSTACK-3596
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Deploy VM request is sent without providing the Domain id . Cloudstack mandates to provide domain id along with account name.
> 
> Fix is to include domain id to resolve script failure (Execute cmd: deployvirtualmachine failed, due to: errorCode: 431, errorText:Account must be specified with domainId parameter)
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_accounts.py 65c0c6f 
> 
> Diff: https://reviews.apache.org/r/12700/diff/
> 
> 
> Testing
> -------
> 
> Tested with the change. Now test is passed.
> 
> 
> Thanks,
> 
> sailaja mada
> 
>

Re: Review Request 12700: Fix for CLOUDSTACK-3596 to include domain id

Posted by sailaja mada <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12700/
-----------------------------------------------------------

(Updated July 17, 2013, 6:10 p.m.)


Review request for cloudstack and Prasanna Santhanam.


Bugs: CLOUDSTACK-3596


Repository: cloudstack-git


Description
-------

Deploy VM request is sent without providing the Domain id . Cloudstack mandates to provide domain id along with account name.

Fix is to include domain id to resolve script failure (Execute cmd: deployvirtualmachine failed, due to: errorCode: 431, errorText:Account must be specified with domainId parameter)


Diffs
-----

  test/integration/component/test_accounts.py 65c0c6f 

Diff: https://reviews.apache.org/r/12700/diff/


Testing
-------

Tested with the change. Now test is passed.


Thanks,

sailaja mada