You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by we...@apache.org on 2022/10/11 08:52:48 UTC

[dolphinscheduler] branch dev updated: [fix] Fix error problem on h2 startup data quality rule management page (#12108)

This is an automated email from the ASF dual-hosted git repository.

wenjun pushed a commit to branch dev
in repository https://gitbox.apache.org/repos/asf/dolphinscheduler.git


The following commit(s) were added to refs/heads/dev by this push:
     new 04e1b88c1c [fix] Fix error problem on h2 startup data quality rule management page (#12108)
04e1b88c1c is described below

commit 04e1b88c1c423ca9216af34539cdedf1ac405e82
Author: jegger <60...@users.noreply.github.com>
AuthorDate: Tue Oct 11 16:52:35 2022 +0800

    [fix] Fix error problem on h2 startup data quality rule management page (#12108)
    
    Co-authored-by: jegger <zh...@163.com>
---
 .../dao/mapper/DqRuleInputEntryMapper.xml          |  2 +-
 .../dao/mapper/DqRuleInputEntryMapperTest.java     | 57 ++++++++++++++++++++++
 2 files changed, 58 insertions(+), 1 deletion(-)

diff --git a/dolphinscheduler-dao/src/main/resources/org/apache/dolphinscheduler/dao/mapper/DqRuleInputEntryMapper.xml b/dolphinscheduler-dao/src/main/resources/org/apache/dolphinscheduler/dao/mapper/DqRuleInputEntryMapper.xml
index b898e014ca..07db1d3e75 100644
--- a/dolphinscheduler-dao/src/main/resources/org/apache/dolphinscheduler/dao/mapper/DqRuleInputEntryMapper.xml
+++ b/dolphinscheduler-dao/src/main/resources/org/apache/dolphinscheduler/dao/mapper/DqRuleInputEntryMapper.xml
@@ -24,7 +24,7 @@
                a.field,
                a.type,
                a.title,
-               a.value,
+               a.`value`,
                a.options,
                a.placeholder,
                a.option_source_type,
diff --git a/dolphinscheduler-dao/src/test/java/org/apache/dolphinscheduler/dao/mapper/DqRuleInputEntryMapperTest.java b/dolphinscheduler-dao/src/test/java/org/apache/dolphinscheduler/dao/mapper/DqRuleInputEntryMapperTest.java
new file mode 100644
index 0000000000..6314f99cb1
--- /dev/null
+++ b/dolphinscheduler-dao/src/test/java/org/apache/dolphinscheduler/dao/mapper/DqRuleInputEntryMapperTest.java
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.dolphinscheduler.dao.mapper;
+
+import com.baomidou.mybatisplus.core.metadata.IPage;
+import com.baomidou.mybatisplus.extension.plugins.pagination.Page;
+import org.apache.dolphinscheduler.dao.BaseDaoTest;
+import org.apache.dolphinscheduler.dao.entity.DqRule;
+import org.apache.dolphinscheduler.dao.entity.DqRuleInputEntry;
+import org.junit.Test;
+import org.springframework.beans.factory.annotation.Autowired;
+
+import java.util.List;
+
+/**
+ * DQC rule mapper UT.
+ */
+public class DqRuleInputEntryMapperTest extends BaseDaoTest {
+    @Autowired
+    private DqRuleInputEntryMapper dqRuleInputEntryMapper;
+
+    @Autowired
+    private DqRuleMapper dqRuleMapper;
+
+    @Test
+    public void testDqcRulePageList() {
+
+        Page<DqRule> page = new Page<>(1, 10);
+
+        IPage<DqRule> dqRulePage =
+                dqRuleMapper.queryRuleListPaging(
+                        page,
+                        "",
+                        -1,
+                        null,
+                        null);
+
+        dqRulePage.getRecords().forEach(rule -> {
+            final List<DqRuleInputEntry> ruleInputEntryList = dqRuleInputEntryMapper.getRuleInputEntryList(1);
+            assert ruleInputEntryList != null;
+        });
+    }
+}