You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by "Hudson (JIRA)" <ji...@apache.org> on 2018/12/14 00:38:04 UTC

[jira] [Commented] (HBASE-19551) hbck -boundaries doesn't work correctly

    [ https://issues.apache.org/jira/browse/HBASE-19551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16720748#comment-16720748 ] 

Hudson commented on HBASE-19551:
--------------------------------

SUCCESS: Integrated in Jenkins build HBase-1.3-IT #509 (See [https://builds.apache.org/job/HBase-1.3-IT/509/])
HBASE-19551 hbck -boundaries doesn't work correctly (Toshihiro Suzuki) (apurtell: rev 217ee60fb4538392d34cccc5e581725e79dc53ed)
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/util/hbck/HbckTestingUtil.java


> hbck -boundaries doesn't work correctly
> ---------------------------------------
>
>                 Key: HBASE-19551
>                 URL: https://issues.apache.org/jira/browse/HBASE-19551
>             Project: HBase
>          Issue Type: Bug
>          Components: hbck
>            Reporter: Toshihiro Suzuki
>            Assignee: Toshihiro Suzuki
>            Priority: Major
>             Fix For: 1.4.1, 1.5.0, 1.3.3
>
>         Attachments: HBASE-19551.branch-1.patch, HBASE-19551.patch
>
>
> Currently, in HBaseFsck#checkRegionBoundaries(), it seems like keys from reader.getFirstKey() and reader.getLastKey() are directly compared by ByteArrayComparator:
> https://github.com/apache/hbase/blob/9d0c7c6dfbcba0907cbbc2244eac570fcc4d58a5/hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java#L864-L865
> https://github.com/apache/hbase/blob/9d0c7c6dfbcba0907cbbc2244eac570fcc4d58a5/hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java#L869-L870
> This is not correct because the keys consist of a key length and key itself. We should compare rowkeys or the only key itself (by removing a key length).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)