You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@jackrabbit.apache.org by GitBox <gi...@apache.org> on 2022/09/23 12:24:19 UTC

[GitHub] [jackrabbit-oak] smiroslav commented on a diff in pull request #698: OAK-9928 Add benchmark for access of binary values in cloud DataStore

smiroslav commented on code in PR #698:
URL: https://github.com/apache/jackrabbit-oak/pull/698#discussion_r978577801


##########
oak-run-commons/src/main/java/org/apache/jackrabbit/oak/fixture/SegmentTarFixture.java:
##########
@@ -346,6 +354,7 @@ public Oak[] setUpCluster(int n, StatisticsProvider statsProvider) throws Except
                     .withSegmentCacheSize(segmentCacheSize)
                     .withMemoryMapping(memoryMapping)
                     .withStrictVersionCheck(true)
+                    .withBinariesInlineThreshold(binariesInlineThreshold)

Review Comment:
   Does it make sense to use this option in other methods where ```FileStoreBuilder``` is being created?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org