[GitHub] [avro] zcsizmadia commented on a diff in pull request #1956: AVRO-3670: Add NET 7.0 support

[GitBox <gi...@apache.org>]

zcsizmadia commented on code in PR #1956:
URL: https://github.com/apache/avro/pull/1956#discussion_r1020797229


##########
lang/csharp/src/apache/benchmark/Avro.benchmark.csproj:
##########
@@ -31,6 +31,12 @@
     <IsPackable>false</IsPackable>
   </PropertyGroup>
 
+  <PropertyGroup>
+    <!-- Some schemas use lower cased names, which causes some class names being lower case only -->
+    <!-- e.g. The type name 'test' only contains lower-cased ascii characters. Such names may become reserved for the language. -->
+    <NoWarn>$(NoWarn);CS8981</NoWarn>
+  </PropertyGroup>

Review Comment:
   This disables that warning only in the becnchmark project. There was only 1 warning  for https://github.com/apache/avro/blob/master/lang/csharp/src/apache/benchmark/org/apache/avro/benchmark/small/test.cs#L33. Since that file was originally generated by avrogen, I did not wanto to change the actual class name or disable the warning in that specific file.
   
   All other projects will generate that warning.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org