You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by zh...@apache.org on 2008/03/18 22:08:10 UTC
svn commit: r638569 - in /incubator/shindig/trunk/java/gadgets/src:
main/java/org/apache/shindig/gadgets/spec/ModulePrefs.java
test/java/org/apache/shindig/gadgets/spec/ModulePrefsTest.java
Author: zhen
Date: Tue Mar 18 14:08:08 2008
New Revision: 638569
URL: http://svn.apache.org/viewvc?rev=638569&view=rev
Log:
Minor fixes for ModulePrefs.
Modified:
incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/spec/ModulePrefs.java
incubator/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/spec/ModulePrefsTest.java
Modified: incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/spec/ModulePrefs.java
URL: http://svn.apache.org/viewvc/incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/spec/ModulePrefs.java?rev=638569&r1=638568&r2=638569&view=diff
==============================================================================
--- incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/spec/ModulePrefs.java (original)
+++ incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/spec/ModulePrefs.java Tue Mar 18 14:08:08 2008
@@ -428,11 +428,11 @@
directoryTitle = XmlUtil.getAttribute(element, "directory_title", "");
screenshot = XmlUtil.getUriAttribute(element, "screenshot", emptyUri);
thumbnail = XmlUtil.getUriAttribute(element, "thumbnail", emptyUri);
- showStats = XmlUtil.getAttribute(element, "show_stats", "") == "true";
- showInDirectory = XmlUtil.getAttribute(element, "show_in_directory", "") == "true";
- singleton = XmlUtil.getAttribute(element, "singleton", "") == "true";
- scaling = XmlUtil.getAttribute(element, "scaling", "") == "true";
- scrolling = XmlUtil.getAttribute(element, "scrolling", "") == "true";
+ showStats = XmlUtil.getBoolAttribute(element, "show_stats");
+ showInDirectory = XmlUtil.getBoolAttribute(element, "show_in_directory");
+ singleton = XmlUtil.getBoolAttribute(element, "singleton");
+ scaling = XmlUtil.getBoolAttribute(element, "scaling");
+ scrolling = XmlUtil.getBoolAttribute(element, "scrolling");
String height = XmlUtil.getAttribute(element, "height");
if (height == null) {
Modified: incubator/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/spec/ModulePrefsTest.java
URL: http://svn.apache.org/viewvc/incubator/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/spec/ModulePrefsTest.java?rev=638569&r1=638568&r2=638569&view=diff
==============================================================================
--- incubator/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/spec/ModulePrefsTest.java (original)
+++ incubator/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/spec/ModulePrefsTest.java Tue Mar 18 14:08:08 2008
@@ -41,7 +41,7 @@
" directory_title=\"directory_title\"" +
" width=\"1\"" +
" height=\"2\"" +
- " category1=\"category1\"" +
+ " category=\"category\"" +
" category2=\"category2\">" +
" <Require feature=\"require\"/>" +
" <Optional feature=\"optional\"/>" +
@@ -60,7 +60,7 @@
assertEquals("directory_title", prefs.getDirectoryTitle());
assertEquals(1, prefs.getWidth());
assertEquals(2, prefs.getHeight());
- assertEquals("category1", prefs.getCategories().get(0));
+ assertEquals("category", prefs.getCategories().get(0));
assertEquals("category2", prefs.getCategories().get(1));
assertEquals(true, prefs.getFeatures().get("require").getRequired());
assertEquals(false, prefs.getFeatures().get("optional").getRequired());