You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2022/01/02 03:57:40 UTC
[GitHub] [fineract] ptuomola opened a new pull request #2011: FINERACT-1198: Fixing incremental build for Gradle
ptuomola opened a new pull request #2011:
URL: https://github.com/apache/fineract/pull/2011
## Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated [Apache Fineract JIRA ticket](https://github.com/apache/fineract/pull/1284).
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [ ] Create/update unit or integration tests for verifying the changes made.
- [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm with details of any API changes
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vidakovic merged pull request #2011: FINERACT-1198: Fixing incremental build for Gradle
Posted by GitBox <gi...@apache.org>.
vidakovic merged pull request #2011:
URL: https://github.com/apache/fineract/pull/2011
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vidakovic commented on pull request #2011: FINERACT-1198: Fixing incremental build for Gradle
Posted by GitBox <gi...@apache.org>.
vidakovic commented on pull request #2011:
URL: https://github.com/apache/fineract/pull/2011#issuecomment-1003704490
@ptuomola ... this reminds me that I wanted to discuss another improvement to make the build.gradle files a little bit cleaner... this would especially come in handy in cases like this where you have a bit more code... the gist: we could place parts of the build script in "buildSrc"; you can place basically any Groovy/Gradle file there (there's a bit of a naming convention) and pre-built those "tasks" (technically the results are plugins). Nice side effect: should also speed up the build with proper caching in place. FYI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ptuomola commented on pull request #2011: FINERACT-1198: Fixing incremental build for Gradle
Posted by GitBox <gi...@apache.org>.
ptuomola commented on pull request #2011:
URL: https://github.com/apache/fineract/pull/2011#issuecomment-1003670628
@vidakovic can you have a look at this one... at least for me it fixes the incremental compile issue with Gradle?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org