You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2022/03/08 10:39:13 UTC

[GitHub] [hive] ayushtkn commented on a change in pull request #3058: HIVE-25990: Optimise multiple copies in case of CTAS in external tables for Object stores.

ayushtkn commented on a change in pull request #3058:
URL: https://github.com/apache/hive/pull/3058#discussion_r821537432



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java
##########
@@ -1514,6 +1523,17 @@ public static void mvFileToFinalPath(Path specPath, Configuration hconf,
     fs.delete(taskTmpPath, true);
   }
 
+  private static void createFileList(Set<FileStatus> filesKept, Path srcPath, Path targetPath, FileSystem fs)
+      throws IOException {
+    try (FSDataOutputStream outStream = fs.create(new Path(targetPath, BLOB_FILES_KEPT))) {
+      outStream.writeBytes(srcPath.toString() + System.lineSeparator());

Review comment:
       Have added a comment above explaining the reason, as discussed offline




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org