You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-dev@lucene.apache.org by "Kay Kay (JIRA)" <ji...@apache.org> on 2009/01/19 19:49:59 UTC

[jira] Created: (SOLR-970) SolrPluginUtils#parseQueryStrings(SolrQueryRequest) - using LinkedList for the internal impl of return type List

SolrPluginUtils#parseQueryStrings(SolrQueryRequest) - using LinkedList for the internal impl of return type List 
-----------------------------------------------------------------------------------------------------------------

                 Key: SOLR-970
                 URL: https://issues.apache.org/jira/browse/SOLR-970
             Project: Solr
          Issue Type: Improvement
         Environment: Java 6, Tomcat 6
            Reporter: Kay Kay
            Priority: Minor
         Attachments: SOLR-970.patch

Is there a specific reason to use LinkedList for the internal implementation of List<?>  . 

ArrayList provides a better locality of reference than a LinkedList .  Addition at the end of the list ( the default behavior of .add() ) is expensive for LinkedList again. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SOLR-970) SolrPluginUtils#parseQueryStrings(SolrQueryRequest) - using LinkedList for the internal impl of return type List

Posted by "Kay Kay (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kay Kay updated SOLR-970:
-------------------------

    Fix Version/s: 1.4

> SolrPluginUtils#parseQueryStrings(SolrQueryRequest) - using LinkedList for the internal impl of return type List 
> -----------------------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-970
>                 URL: https://issues.apache.org/jira/browse/SOLR-970
>             Project: Solr
>          Issue Type: Improvement
>         Environment: Java 6, Tomcat 6
>            Reporter: Kay Kay
>            Priority: Minor
>             Fix For: 1.4
>
>         Attachments: SOLR-970.patch
>
>   Original Estimate: 0.08h
>  Remaining Estimate: 0.08h
>
> Is there a specific reason to use LinkedList for the internal implementation of List<?>  . 
> ArrayList provides a better locality of reference than a LinkedList .  Addition at the end of the list ( the default behavior of .add() ) is expensive for LinkedList again. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (SOLR-970) SolrPluginUtils#parseQueryStrings(SolrQueryRequest) - replacing LinkedList with ArrayList for the internal impl of return type

Posted by "Hoss Man (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hoss Man resolved SOLR-970.
---------------------------

    Resolution: Fixed
      Assignee: Hoss Man

nice catch Kay

Committed revision 737464.


> SolrPluginUtils#parseQueryStrings(SolrQueryRequest) - replacing LinkedList with ArrayList for the internal impl of return type 
> -------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-970
>                 URL: https://issues.apache.org/jira/browse/SOLR-970
>             Project: Solr
>          Issue Type: Improvement
>         Environment: Java 6, Tomcat 6
>            Reporter: Kay Kay
>            Assignee: Hoss Man
>            Priority: Minor
>             Fix For: 1.4
>
>         Attachments: SOLR-970.patch
>
>   Original Estimate: 0.08h
>  Remaining Estimate: 0.08h
>
> Is there a specific reason to use LinkedList for the internal implementation of List<?>  . 
> ArrayList provides a better locality of reference than a LinkedList .  Addition at the end of the list ( the default behavior of .add() ) is expensive for LinkedList again. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SOLR-970) SolrPluginUtils#parseQueryStrings(SolrQueryRequest) - using LinkedList for the internal impl of return type List

Posted by "Kay Kay (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kay Kay updated SOLR-970:
-------------------------

    Attachment: SOLR-970.patch

> SolrPluginUtils#parseQueryStrings(SolrQueryRequest) - using LinkedList for the internal impl of return type List 
> -----------------------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-970
>                 URL: https://issues.apache.org/jira/browse/SOLR-970
>             Project: Solr
>          Issue Type: Improvement
>         Environment: Java 6, Tomcat 6
>            Reporter: Kay Kay
>            Priority: Minor
>             Fix For: 1.4
>
>         Attachments: SOLR-970.patch
>
>   Original Estimate: 0.08h
>  Remaining Estimate: 0.08h
>
> Is there a specific reason to use LinkedList for the internal implementation of List<?>  . 
> ArrayList provides a better locality of reference than a LinkedList .  Addition at the end of the list ( the default behavior of .add() ) is expensive for LinkedList again. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SOLR-970) SolrPluginUtils#parseQueryStrings(SolrQueryRequest) - replacing LinkedList with ArrayList for the internal impl of return type

Posted by "Kay Kay (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kay Kay updated SOLR-970:
-------------------------

    Summary: SolrPluginUtils#parseQueryStrings(SolrQueryRequest) - replacing LinkedList with ArrayList for the internal impl of return type   (was: SolrPluginUtils#parseQueryStrings(SolrQueryRequest) - using LinkedList for the internal impl of return type List )

> SolrPluginUtils#parseQueryStrings(SolrQueryRequest) - replacing LinkedList with ArrayList for the internal impl of return type 
> -------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-970
>                 URL: https://issues.apache.org/jira/browse/SOLR-970
>             Project: Solr
>          Issue Type: Improvement
>         Environment: Java 6, Tomcat 6
>            Reporter: Kay Kay
>            Priority: Minor
>             Fix For: 1.4
>
>         Attachments: SOLR-970.patch
>
>   Original Estimate: 0.08h
>  Remaining Estimate: 0.08h
>
> Is there a specific reason to use LinkedList for the internal implementation of List<?>  . 
> ArrayList provides a better locality of reference than a LinkedList .  Addition at the end of the list ( the default behavior of .add() ) is expensive for LinkedList again. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (SOLR-970) SolrPluginUtils#parseQueryStrings(SolrQueryRequest) - replacing LinkedList with ArrayList for the internal impl of return type

Posted by "Kay Kay (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kay Kay closed SOLR-970.
------------------------


Thanks  . 

> SolrPluginUtils#parseQueryStrings(SolrQueryRequest) - replacing LinkedList with ArrayList for the internal impl of return type 
> -------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-970
>                 URL: https://issues.apache.org/jira/browse/SOLR-970
>             Project: Solr
>          Issue Type: Improvement
>         Environment: Java 6, Tomcat 6
>            Reporter: Kay Kay
>            Assignee: Hoss Man
>            Priority: Minor
>             Fix For: 1.4
>
>         Attachments: SOLR-970.patch
>
>   Original Estimate: 0.08h
>  Remaining Estimate: 0.08h
>
> Is there a specific reason to use LinkedList for the internal implementation of List<?>  . 
> ArrayList provides a better locality of reference than a LinkedList .  Addition at the end of the list ( the default behavior of .add() ) is expensive for LinkedList again. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.