You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by SolidWallOfCode <gi...@git.apache.org> on 2016/10/19 15:18:11 UTC
[GitHub] trafficserver pull request #1125: Ts 4987: Don't prefer loopback over API se...
GitHub user SolidWallOfCode opened a pull request:
https://github.com/apache/trafficserver/pull/1125
Ts 4987: Don't prefer loopback over API set origin server address.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/SolidWallOfCode/trafficserver ts-4987
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/1125.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1125
----
commit 56e5e912736e9a6b62c23194489133e0bfc95ffc
Author: Persia Aziz <pe...@yahoo-inc.com>
Date: 2016-10-18T19:53:59Z
TS-4978: illegal memory access with ticket_key.filename
commit 17d5a9532d4b768ffd589bfbf1d32d843b70f5d3
Author: Alan M. Carroll <so...@yahoo-inc.com>
Date: 2016-10-19T15:16:15Z
TS-4987: Don't prefer loopback over API set origin server address.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1125: TS-4987: Don't prefer loopback over API set origi...
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/pull/1125
@zwoop this is different; you need to check whether the API set an address *before* worrying about whether it is loopback.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1125: Ts 4987: Don't prefer loopback over API set origi...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1125
Linux build *failed*! See https://ci.trafficserver.apache.org/job/Github-Linux/946/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1125: TS-4987: Don't prefer loopback over API set origi...
Posted by SolidWallOfCode <gi...@git.apache.org>.
Github user SolidWallOfCode commented on the issue:
https://github.com/apache/trafficserver/pull/1125
WIth regard to #1079, this doesn't intersect with that change. This maintains the existing loopback only check, it just does it better by dropping the pointless yet fragile string comparisons.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1125: Ts 4987: Don't prefer loopback over API set origi...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1125
Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/947/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1125: Ts 4987: Don't prefer loopback over API set origi...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1125
FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1054/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1125: TS-4987: Don't prefer loopback over API set origi...
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1125
Looking back, it seems this is basically handled (but better) with #1079 ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1125: Ts 4987: Don't prefer loopback over API set origi...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1125
FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1055/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1125: TS-4987: Don't prefer loopback over API set origi...
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1125
I see. The first portion of this patch is important, whereas the second portion is done (better?) in #1079.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1125: TS-4987: Don't prefer loopback over API se...
Posted by SolidWallOfCode <gi...@git.apache.org>.
Github user SolidWallOfCode closed the pull request at:
https://github.com/apache/trafficserver/pull/1125
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---