[jira] [Closed] (WW-3743) XWorkMapPropertyAccessor calls getProperty twice if the value is null

["Lukasz Lenart (Closed) (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/WW-3743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lukasz Lenart closed WW-3743.
-----------------------------

    Resolution: Fixed
      Assignee: Lukasz Lenart

Thanks for pointing this out. I've also removed some unused code.
                
> XWorkMapPropertyAccessor calls getProperty twice if the value is null
> ---------------------------------------------------------------------
>
>                 Key: WW-3743
>                 URL: https://issues.apache.org/jira/browse/WW-3743
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Value Stack
>    Affects Versions: 2.3.1.1
>            Reporter: Pelladi Gabor
>            Assignee: Lukasz Lenart
>            Priority: Minor
>              Labels: patch, performance
>             Fix For: 2.3.2
>
>         Attachments: WW-3743.diff
>
>
> If you evaluate an OGNL expression which has null value, XWorkMapPropertyAccessor does the evaluation twice.
> First in line 81: result = super.getProperty(context, target, name);
> Second in line 91: return super.getProperty(context, target, name);
> Performance can be improved by removing the second evaluation.
> Line 91: return null;
> This saves an extra evaluation, and at this point we can be sure that the result can only be null.
> Patch is attached.
> Please review it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira