[GitHub] [helix] xyuanlu commented on a diff in pull request #2388: TTL Node Interface Methods

["xyuanlu (via GitHub)" <gi...@apache.org>]

xyuanlu commented on code in PR #2388:
URL: https://github.com/apache/helix/pull/2388#discussion_r1123797540


##########
meta-client/src/main/java/org/apache/helix/metaclient/api/MetaClientInterface.java:
##########
@@ -79,6 +79,9 @@ enum ConnectState {
   class Stat {
     private final int _version;
     private final EntryMode _entryMode;
+    private long _expiryTime;

Review Comment:
   Please consider add some comments here. They are in what time format? Are they relative time or absolute time etc
   



##########
meta-client/src/main/java/org/apache/helix/metaclient/api/MetaClientInterface.java:
##########
@@ -79,6 +79,9 @@ enum ConnectState {
   class Stat {
     private final int _version;
     private final EntryMode _entryMode;
+    private long _expiryTime;

Review Comment:
   Please consider adding some comments here. They are in what time format? Are they relative time or absolute time etc
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org