You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by rxin <gi...@git.apache.org> on 2018/07/20 01:39:37 UTC

[GitHub] spark pull request #21822: [SPARK-24865] Remove AnalysisBarrier - WIP

Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21822#discussion_r203918981
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala ---
    @@ -533,7 +537,8 @@ trait CheckAnalysis extends PredicateHelper {
     
         // Simplify the predicates before validating any unsupported correlation patterns
         // in the plan.
    -    BooleanSimplification(sub).foreachUp {
    +    // TODO(rxin): Why did this need to call BooleanSimplification???
    --- End diff --
    
    cc @dilipbiswal @cloud-fan @gatorsmile 
    
    Why did we need BooleanSimplification here?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org