[GitHub] [pinot] Jackie-Jiang commented on a change in pull request #7645: to handle datetime column consistently

[GitBox <gi...@apache.org>]

Jackie-Jiang commented on a change in pull request #7645:
URL: https://github.com/apache/pinot/pull/7645#discussion_r738858459



##########
File path: pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/creator/SegmentGeneratorConfig.java
##########
@@ -286,18 +285,13 @@ public void setCustomProperties(Map<String, String> properties) {
     _customProperties.putAll(properties);
   }
 
-  public void setSimpleDateFormat(String simpleDateFormat) {
+  private void setSimpleDateFormat(DateTimeFormatSpec formatSpec) {

Review comment:
       Not sure if this API is used by external code.
   Let's provide another public API `setDateTimeFormatSpec()` and don't assume it is `SIMPLE_DATE` format




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org