[GitHub] [cassandra] ekaterinadimitrova2 commented on a change in pull request #1137: [WIP] CASSANDRA-16851: upgrade Jackson 2.9->2.12

[GitBox <gi...@apache.org>]

ekaterinadimitrova2 commented on a change in pull request #1137:
URL: https://github.com/apache/cassandra/pull/1137#discussion_r696170134



##########
File path: src/java/org/apache/cassandra/cql3/Json.java
##########
@@ -42,7 +42,7 @@
      */
     public static String quoteAsJsonString(String s)
     {
-        return new String(BufferRecyclers.getJsonStringEncoder().quoteAsString(s));
+        return new String(JsonStringEncoder.getInstance().quoteAsString(s));

Review comment:
       > For trunk it might be enough to rely on full stress/load-testing: I doubt there will be severe slowdown (added memory usage is all transient garbage), but in theory there could be increased GC which could lead to minor observable performance regression.
   Then probably better to do it for trunk only probably? I expect that there the big in the game probably will test significantly before a major release to catch any regressions? @michaelsembwever , WDYT about that? I am uncertain to be honest




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org