You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/11/29 15:59:14 UTC
[GitHub] [shardingsphere] Pace2Car opened a new pull request, #22513: Refactor sharding example with ShardingSphereDriver
Pace2Car opened a new pull request, #22513:
URL: https://github.com/apache/shardingsphere/pull/22513
For #22469.
Changes proposed in this pull request:
- Refactor configuration to use ShardingSphereDriver
- Remove Spring configuration example
---
Before committing this PR, I'm sure that I have checked the following options:
- [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [ ] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on pull request #22513: Refactor sharding example with ShardingSphereDriver
Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on PR #22513:
URL: https://github.com/apache/shardingsphere/pull/22513#issuecomment-1330896580
@Pace2Car Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang merged pull request #22513: Refactor sharding example with ShardingSphereDriver
Posted by GitBox <gi...@apache.org>.
RaigorJiang merged PR #22513:
URL: https://github.com/apache/shardingsphere/pull/22513
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #22513: Refactor sharding example with ShardingSphereDriver
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #22513:
URL: https://github.com/apache/shardingsphere/pull/22513#issuecomment-1330928719
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/22513?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#22513](https://codecov.io/gh/apache/shardingsphere/pull/22513?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (87f99f6) into [master](https://codecov.io/gh/apache/shardingsphere/commit/38f7e459c83144a8c0c72e5e885ec1d32df693ce?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (38f7e45) will **decrease** coverage by `0.07%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #22513 +/- ##
============================================
- Coverage 51.05% 50.98% -0.08%
- Complexity 2512 2514 +2
============================================
Files 4179 4185 +6
Lines 58109 58237 +128
Branches 9891 9902 +11
============================================
+ Hits 29670 29691 +21
- Misses 25911 26016 +105
- Partials 2528 2530 +2
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/22513?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...handler/distsql/ral/hint/enums/HintSourceType.java](https://codecov.io/gh/apache/shardingsphere/pull/22513/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9oYW5kbGVyL2Rpc3RzcWwvcmFsL2hpbnQvZW51bXMvSGludFNvdXJjZVR5cGUuamF2YQ==) | `0.00% <0.00%> (-42.86%)` | :arrow_down: |
| [...ine/core/sqlbuilder/DefaultPipelineSQLBuilder.java](https://codecov.io/gh/apache/shardingsphere/pull/22513/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGF0YS9waXBlbGluZS9jb3JlL3NxbGJ1aWxkZXIvRGVmYXVsdFBpcGVsaW5lU1FMQnVpbGRlci5qYXZh) | `20.00% <0.00%> (-30.00%)` | :arrow_down: |
| [...er/ShardingSphereSchemaDataRegistrySubscriber.java](https://codecov.io/gh/apache/shardingsphere/pull/22513/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bW9kZS90eXBlL2NsdXN0ZXIvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvbW9kZS9tYW5hZ2VyL2NsdXN0ZXIvY29vcmRpbmF0b3IvcmVnaXN0cnkvbWV0YWRhdGEvc3Vic2NyaWJlci9TaGFyZGluZ1NwaGVyZVNjaGVtYURhdGFSZWdpc3RyeVN1YnNjcmliZXIuamF2YQ==) | `33.33% <0.00%> (-16.67%)` | :arrow_down: |
| [...proxy/backend/config/ProxyConfigurationLoader.java](https://codecov.io/gh/apache/shardingsphere/pull/22513/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9jb25maWcvUHJveHlDb25maWd1cmF0aW9uTG9hZGVyLmphdmE=) | `60.00% <0.00%> (-12.10%)` | :arrow_down: |
| [...e/test/sql/parser/internal/cases/sql/SQLCases.java](https://codecov.io/gh/apache/shardingsphere/pull/22513/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9wYXJzZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3Rlc3Qvc3FsL3BhcnNlci9pbnRlcm5hbC9jYXNlcy9zcWwvU1FMQ2FzZXMuamF2YQ==) | `90.00% <0.00%> (-1.67%)` | :arrow_down: |
| [...rdingsphere/agent/core/spi/AgentServiceLoader.java](https://codecov.io/gh/apache/shardingsphere/pull/22513/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvY29yZS9zcGkvQWdlbnRTZXJ2aWNlTG9hZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...ingsphere/agent/core/plugin/AgentPluginLoader.java](https://codecov.io/gh/apache/shardingsphere/pull/22513/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvY29yZS9wbHVnaW4vQWdlbnRQbHVnaW5Mb2FkZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...phere/agent/core/config/path/AgentPathBuilder.java](https://codecov.io/gh/apache/shardingsphere/pull/22513/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvY29yZS9jb25maWcvcGF0aC9BZ2VudFBhdGhCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...ingsphere/agent/bootstrap/ShardingSphereAgent.java](https://codecov.io/gh/apache/shardingsphere/pull/22513/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvYm9vdHN0cmFwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9hZ2VudC9ib290c3RyYXAvU2hhcmRpbmdTcGhlcmVBZ2VudC5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...here/agent/core/config/yaml/engine/YamlEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/22513/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvY29yZS9jb25maWcveWFtbC9lbmdpbmUvWWFtbEVuZ2luZS5qYXZh) | `0.00% <0.00%> (ø)` | |
| ... and [34 more](https://codecov.io/gh/apache/shardingsphere/pull/22513/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org