You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@royale.apache.org by ha...@apache.org on 2018/08/31 11:45:39 UTC

[royale-asjs] branch feature/Merge_MXRoyale_To_Develop updated: I think this could be reverted

This is an automated email from the ASF dual-hosted git repository.

harbs pushed a commit to branch feature/Merge_MXRoyale_To_Develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git


The following commit(s) were added to refs/heads/feature/Merge_MXRoyale_To_Develop by this push:
     new 3f57144  I think this could be reverted
3f57144 is described below

commit 3f5714479608d0ce249a3c9fcaafd8976bb0cfcb
Author: Harbs <ha...@in-tools.com>
AuthorDate: Fri Aug 31 14:45:31 2018 +0300

    I think this could be reverted
    
    It seems to build ok
---
 .../src/main/royale/org/apache/royale/html/beads/DataGridView.as     | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/frameworks/projects/Basic/src/main/royale/org/apache/royale/html/beads/DataGridView.as b/frameworks/projects/Basic/src/main/royale/org/apache/royale/html/beads/DataGridView.as
index 90df578..89689f0 100644
--- a/frameworks/projects/Basic/src/main/royale/org/apache/royale/html/beads/DataGridView.as
+++ b/frameworks/projects/Basic/src/main/royale/org/apache/royale/html/beads/DataGridView.as
@@ -34,8 +34,7 @@ package org.apache.royale.html.beads
 	import org.apache.royale.html.Container;
 	import org.apache.royale.html.DataGridButtonBar;
 	import org.apache.royale.html.beads.layouts.ButtonBarLayout;
-    import org.apache.royale.html.supportClasses.DataGridColumnList;
-    import org.apache.royale.html.supportClasses.IDataGridColumnList;
+	import org.apache.royale.html.supportClasses.IDataGridColumnList;
 	import org.apache.royale.html.supportClasses.IDataGridColumn;
 	import org.apache.royale.html.supportClasses.Viewport;
 
@@ -228,7 +227,7 @@ package org.apache.royale.html.beads
 				{
 					var dataGridColumn:IDataGridColumn = sharedModel.columns[i] as IDataGridColumn;
 
-					var list:DataGridColumnList = new columnClass();
+					var list:IDataGridColumnList = new columnClass();
 					
 					if (i == 0)
 					{


Re: [royale-asjs] branch feature/Merge_MXRoyale_To_Develop updated: I think this could be reverted

Posted by Piotr Zarzycki <pi...@gmail.com>.
Harbs,

Can't believe but it's passing now without the problem. Don't understand.
;)

pt., 31 sie 2018 o 14:20 Piotr Zarzycki <pi...@gmail.com>
napisał(a):

> This is how it was before and it is failing for me in ANT build - It's not
> for you ?
>
> pt., 31 sie 2018 o 13:45 <ha...@apache.org> napisał(a):
>
>> This is an automated email from the ASF dual-hosted git repository.
>>
>> harbs pushed a commit to branch feature/Merge_MXRoyale_To_Develop
>> in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
>>
>>
>> The following commit(s) were added to
>> refs/heads/feature/Merge_MXRoyale_To_Develop by this push:
>>      new 3f57144  I think this could be reverted
>> 3f57144 is described below
>>
>> commit 3f5714479608d0ce249a3c9fcaafd8976bb0cfcb
>> Author: Harbs <ha...@in-tools.com>
>> AuthorDate: Fri Aug 31 14:45:31 2018 +0300
>>
>>     I think this could be reverted
>>
>>     It seems to build ok
>> ---
>>  .../src/main/royale/org/apache/royale/html/beads/DataGridView.as     | 5
>> ++---
>>  1 file changed, 2 insertions(+), 3 deletions(-)
>>
>> diff --git
>> a/frameworks/projects/Basic/src/main/royale/org/apache/royale/html/beads/DataGridView.as
>> b/frameworks/projects/Basic/src/main/royale/org/apache/royale/html/beads/DataGridView.as
>> index 90df578..89689f0 100644
>> ---
>> a/frameworks/projects/Basic/src/main/royale/org/apache/royale/html/beads/DataGridView.as
>> +++
>> b/frameworks/projects/Basic/src/main/royale/org/apache/royale/html/beads/DataGridView.as
>> @@ -34,8 +34,7 @@ package org.apache.royale.html.beads
>>         import org.apache.royale.html.Container;
>>         import org.apache.royale.html.DataGridButtonBar;
>>         import org.apache.royale.html.beads.layouts.ButtonBarLayout;
>> -    import org.apache.royale.html.supportClasses.DataGridColumnList;
>> -    import org.apache.royale.html.supportClasses.IDataGridColumnList;
>> +       import org.apache.royale.html.supportClasses.IDataGridColumnList;
>>         import org.apache.royale.html.supportClasses.IDataGridColumn;
>>         import org.apache.royale.html.supportClasses.Viewport;
>>
>> @@ -228,7 +227,7 @@ package org.apache.royale.html.beads
>>                                 {
>>                                         var
>> dataGridColumn:IDataGridColumn = sharedModel.columns[i] as IDataGridColumn;
>>
>> -                                       var list:DataGridColumnList = new
>> columnClass();
>> +                                       var list:IDataGridColumnList =
>> new columnClass();
>>
>>                                         if (i == 0)
>>                                         {
>>
>>
>
> --
>
> Piotr Zarzycki
>
> Patreon: *https://www.patreon.com/piotrzarzycki
> <https://www.patreon.com/piotrzarzycki>*
>


-- 

Piotr Zarzycki

Patreon: *https://www.patreon.com/piotrzarzycki
<https://www.patreon.com/piotrzarzycki>*

Re: [royale-asjs] branch feature/Merge_MXRoyale_To_Develop updated: I think this could be reverted

Posted by Piotr Zarzycki <pi...@gmail.com>.
This is how it was before and it is failing for me in ANT build - It's not
for you ?

pt., 31 sie 2018 o 13:45 <ha...@apache.org> napisał(a):

> This is an automated email from the ASF dual-hosted git repository.
>
> harbs pushed a commit to branch feature/Merge_MXRoyale_To_Develop
> in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
>
>
> The following commit(s) were added to
> refs/heads/feature/Merge_MXRoyale_To_Develop by this push:
>      new 3f57144  I think this could be reverted
> 3f57144 is described below
>
> commit 3f5714479608d0ce249a3c9fcaafd8976bb0cfcb
> Author: Harbs <ha...@in-tools.com>
> AuthorDate: Fri Aug 31 14:45:31 2018 +0300
>
>     I think this could be reverted
>
>     It seems to build ok
> ---
>  .../src/main/royale/org/apache/royale/html/beads/DataGridView.as     | 5
> ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git
> a/frameworks/projects/Basic/src/main/royale/org/apache/royale/html/beads/DataGridView.as
> b/frameworks/projects/Basic/src/main/royale/org/apache/royale/html/beads/DataGridView.as
> index 90df578..89689f0 100644
> ---
> a/frameworks/projects/Basic/src/main/royale/org/apache/royale/html/beads/DataGridView.as
> +++
> b/frameworks/projects/Basic/src/main/royale/org/apache/royale/html/beads/DataGridView.as
> @@ -34,8 +34,7 @@ package org.apache.royale.html.beads
>         import org.apache.royale.html.Container;
>         import org.apache.royale.html.DataGridButtonBar;
>         import org.apache.royale.html.beads.layouts.ButtonBarLayout;
> -    import org.apache.royale.html.supportClasses.DataGridColumnList;
> -    import org.apache.royale.html.supportClasses.IDataGridColumnList;
> +       import org.apache.royale.html.supportClasses.IDataGridColumnList;
>         import org.apache.royale.html.supportClasses.IDataGridColumn;
>         import org.apache.royale.html.supportClasses.Viewport;
>
> @@ -228,7 +227,7 @@ package org.apache.royale.html.beads
>                                 {
>                                         var dataGridColumn:IDataGridColumn
> = sharedModel.columns[i] as IDataGridColumn;
>
> -                                       var list:DataGridColumnList = new
> columnClass();
> +                                       var list:IDataGridColumnList = new
> columnClass();
>
>                                         if (i == 0)
>                                         {
>
>

-- 

Piotr Zarzycki

Patreon: *https://www.patreon.com/piotrzarzycki
<https://www.patreon.com/piotrzarzycki>*