[kudu-CR] [flaky tests] Address SIGSEGV on ResultTracker while running alter table randomized-test

["David Ribeiro Alves (Code Review)" <ge...@cloudera.org>]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/4629

to look at the new patch set (#3).

Change subject: [flaky tests] Address SIGSEGV on ResultTracker while running alter_table_randomized-test
......................................................................

[flaky tests] Address SIGSEGV on ResultTracker while running alter_table_randomized-test

This addresses a flakyness in the alter_table_randomized-test whereby
calling ResultTracker::FailAndRespond() on a transaction that was never
tracked (a legal and possible thing for follower transactions) would
cause a SIGSEGV. The SIGSEGV is caused because we try to deference
the CompletionRecord* to track its memory, even though we already
know it doesn't exist.

This is hard to reproduce in either exactly once tests, but the change
is pretty obvious.

I also added some comment on how that can happen, it took me a while
to find the path that could cause this (again).

Change-Id: I961af334fa2dd7faff0e95c7a49f2f16b2096fe0
---
M src/kudu/rpc/result_tracker.cc
1 file changed, 5 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/29/4629/3
-- 
To view, visit http://gerrit.cloudera.org:8080/4629
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I961af334fa2dd7faff0e95c7a49f2f16b2096fe0
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>