You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@buildstream.apache.org by GitBox <gi...@apache.org> on 2021/01/25 02:20:44 UTC

[GitHub] [buildstream] gtristan opened a new pull request #1452: Some minor fixes to the yaml/node parsing code

gtristan opened a new pull request #1452:
URL: https://github.com/apache/buildstream/pull/1452


   This patch:
   
   * Adds type safety to `MappingNode.get_str_list()`, which would previously segfault or raise a runtime error when called on a list of lists or a list of dictionaries
   * Ensures that `MappingNode.get_str_list()` does not segfault when given `default=None`
   * Adds a new `allowed_types` to `MappingNode.get_sequence()`, allowing one to conveniently validate the types of the elements in a sequence (otherwise in various places we risk assuming that the user provided a list of dicts and fail to validate sequence elements)
   * Enhances `node.pyi` to add some missing type annotations
   * Adds tests for the `MappingNode.get_str_list()` related fixes
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [buildstream] gtristan merged pull request #1452: Some minor fixes to the yaml/node parsing code

Posted by GitBox <gi...@apache.org>.

gtristan merged pull request #1452:
URL: https://github.com/apache/buildstream/pull/1452


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [buildstream] gtristan merged pull request #1452: Some minor fixes to the yaml/node parsing code

Posted by GitBox <gi...@apache.org>.

gtristan merged pull request #1452:
URL: https://github.com/apache/buildstream/pull/1452


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org