[GitHub] [cassandra] nastra commented on a change in pull request #448: Check if webbrowser._tryorder is not None for python 3

[GitBox <gi...@apache.org>]

nastra commented on a change in pull request #448: Check if webbrowser._tryorder is not None for python 3
URL: https://github.com/apache/cassandra/pull/448#discussion_r401740087
 
 

 ##########
 File path: bin/cqlsh.py
 ##########
 @@ -96,7 +96,7 @@
 # >>> webbrowser._tryorder
 # >>> webbrowser._browser
 #
-if len(webbrowser._tryorder) == 0:
+if webbrowser._tryorder is None or len(webbrowser._tryorder) == 0:
 
 Review comment:
   in a Docker testing environment it's likely that no default browser is installed and so you could end up in https://github.com/python/cpython/blob/3.7/Lib/webbrowser.py#L65, so I'm +1 with the fix here

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org