You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by haosdent huang <ha...@gmail.com> on 2016/01/24 16:18:24 UTC
Review Request 42697: Remove checkpointing field from SlaveInfo after
deprecation.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42697/
-----------------------------------------------------------
Review request for mesos, Adam B and Joerg Schad.
Bugs: MESOS-4340
https://issues.apache.org/jira/browse/MESOS-4340
Repository: mesos
Description
-------
Remove checkpointing field from SlaveInfo after deprecation.
Diffs
-----
docs/slave-recovery.md acf36b9693972641f38a96e8d6b682e02b6cdbb3
include/mesos/mesos.proto 96b911fb370223933df52f9370897871827d2247
src/internal/devolve.cpp 27918f1fc385b1770843697c16a29fd0d376f39d
src/slave/slave.cpp 1f4c8368feb0ce19963577582ce745acfb21aa9f
Diff: https://reviews.apache.org/r/42697/diff/
Testing
-------
Thanks,
haosdent huang
Re: Review Request 42697: Remove checkpointing field from SlaveInfo
after deprecation.
Posted by Joerg Schad <jo...@mesosphere.io>.
> On Jan. 24, 2016, 3:28 p.m., Joerg Schad wrote:
> > include/mesos/mesos.proto, line 482
> > <https://reviews.apache.org/r/42697/diff/1/?file=1218952#file1218952line482>
> >
> > We planned to wait for this deprecation cycle, any reason to change this right now?
>
> haosdent huang wrote:
> I saw
> ```
> // TODO(joerg84): Remove checkpoint field after deprecation cycle starting
> - // with 0.27
> ```
> Do you mean we need submit this since 0.28 here?
>
> Joerg Schad wrote:
> Afaik we have a six month compatability guarantee (after switching to the monthly releases), i.e. we should wait that period after all code using the flag has been removed (or we release 1.0). Discussed that a bit with adam as we were not really sure we need a deprecation cycle here, but as we decided to have one we should stick to it.
>
> haosdent huang wrote:
> Sorry, I think my understand standing about this comment is incorrect. I think "starting with 0.27" means we could do it in 0.27 before. Let me discard this patch.
The deprecation cycle starts with that release. You can still submit the documentation part :-)...
- Joerg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42697/#review116018
-----------------------------------------------------------
On Jan. 24, 2016, 3:26 p.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42697/
> -----------------------------------------------------------
>
> (Updated Jan. 24, 2016, 3:26 p.m.)
>
>
> Review request for mesos, Adam B and Joerg Schad.
>
>
> Bugs: MESOS-4340
> https://issues.apache.org/jira/browse/MESOS-4340
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Remove checkpointing field from SlaveInfo after deprecation.
>
>
> Diffs
> -----
>
> docs/slave-recovery.md acf36b9693972641f38a96e8d6b682e02b6cdbb3
> include/mesos/mesos.proto 96b911fb370223933df52f9370897871827d2247
> src/common/type_utils.cpp 76f48f6a1f5467db032ded8acd296d03353b4172
> src/internal/devolve.cpp 27918f1fc385b1770843697c16a29fd0d376f39d
> src/slave/slave.cpp 1f4c8368feb0ce19963577582ce745acfb21aa9f
>
> Diff: https://reviews.apache.org/r/42697/diff/
>
>
> Testing
> -------
>
> make -j8 check
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 42697: Remove checkpointing field from SlaveInfo
after deprecation.
Posted by haosdent huang <ha...@gmail.com>.
> On Jan. 24, 2016, 3:28 p.m., Joerg Schad wrote:
> > include/mesos/mesos.proto, line 482
> > <https://reviews.apache.org/r/42697/diff/1/?file=1218952#file1218952line482>
> >
> > We planned to wait for this deprecation cycle, any reason to change this right now?
>
> haosdent huang wrote:
> I saw
> ```
> // TODO(joerg84): Remove checkpoint field after deprecation cycle starting
> - // with 0.27
> ```
> Do you mean we need submit this since 0.28 here?
>
> Joerg Schad wrote:
> Afaik we have a six month compatability guarantee (after switching to the monthly releases), i.e. we should wait that period after all code using the flag has been removed (or we release 1.0). Discussed that a bit with adam as we were not really sure we need a deprecation cycle here, but as we decided to have one we should stick to it.
Sorry, I think my understand standing about this comment is incorrect. I think "starting with 0.27" means we could do it in 0.27 before. Let me discard this patch.
- haosdent
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42697/#review116018
-----------------------------------------------------------
On Jan. 24, 2016, 3:26 p.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42697/
> -----------------------------------------------------------
>
> (Updated Jan. 24, 2016, 3:26 p.m.)
>
>
> Review request for mesos, Adam B and Joerg Schad.
>
>
> Bugs: MESOS-4340
> https://issues.apache.org/jira/browse/MESOS-4340
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Remove checkpointing field from SlaveInfo after deprecation.
>
>
> Diffs
> -----
>
> docs/slave-recovery.md acf36b9693972641f38a96e8d6b682e02b6cdbb3
> include/mesos/mesos.proto 96b911fb370223933df52f9370897871827d2247
> src/common/type_utils.cpp 76f48f6a1f5467db032ded8acd296d03353b4172
> src/internal/devolve.cpp 27918f1fc385b1770843697c16a29fd0d376f39d
> src/slave/slave.cpp 1f4c8368feb0ce19963577582ce745acfb21aa9f
>
> Diff: https://reviews.apache.org/r/42697/diff/
>
>
> Testing
> -------
>
> make -j8 check
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 42697: Remove checkpointing field from SlaveInfo
after deprecation.
Posted by Joerg Schad <jo...@mesosphere.io>.
> On Jan. 24, 2016, 3:28 p.m., Joerg Schad wrote:
> > include/mesos/mesos.proto, line 482
> > <https://reviews.apache.org/r/42697/diff/1/?file=1218952#file1218952line482>
> >
> > We planned to wait for this deprecation cycle, any reason to change this right now?
>
> haosdent huang wrote:
> I saw
> ```
> // TODO(joerg84): Remove checkpoint field after deprecation cycle starting
> - // with 0.27
> ```
> Do you mean we need submit this since 0.28 here?
Afaik we have a six month compatability guarantee (after switching to the monthly releases), i.e. we should wait that period after all code using the flag has been removed (or we release 1.0). Discussed that a bit with adam as we were not really sure we need a deprecation cycle here, but as we decided to have one we should stick to it.
- Joerg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42697/#review116018
-----------------------------------------------------------
On Jan. 24, 2016, 3:26 p.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42697/
> -----------------------------------------------------------
>
> (Updated Jan. 24, 2016, 3:26 p.m.)
>
>
> Review request for mesos, Adam B and Joerg Schad.
>
>
> Bugs: MESOS-4340
> https://issues.apache.org/jira/browse/MESOS-4340
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Remove checkpointing field from SlaveInfo after deprecation.
>
>
> Diffs
> -----
>
> docs/slave-recovery.md acf36b9693972641f38a96e8d6b682e02b6cdbb3
> include/mesos/mesos.proto 96b911fb370223933df52f9370897871827d2247
> src/common/type_utils.cpp 76f48f6a1f5467db032ded8acd296d03353b4172
> src/internal/devolve.cpp 27918f1fc385b1770843697c16a29fd0d376f39d
> src/slave/slave.cpp 1f4c8368feb0ce19963577582ce745acfb21aa9f
>
> Diff: https://reviews.apache.org/r/42697/diff/
>
>
> Testing
> -------
>
> make -j8 check
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 42697: Remove checkpointing field from SlaveInfo
after deprecation.
Posted by haosdent huang <ha...@gmail.com>.
> On Jan. 24, 2016, 3:28 p.m., Joerg Schad wrote:
> > include/mesos/mesos.proto, line 482
> > <https://reviews.apache.org/r/42697/diff/1/?file=1218952#file1218952line482>
> >
> > We planned to wait for this deprecation cycle, any reason to change this right now?
I saw
```
// TODO(joerg84): Remove checkpoint field after deprecation cycle starting
- // with 0.27
```
Do you mean we need submit this since 0.28 here?
- haosdent
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42697/#review116018
-----------------------------------------------------------
On Jan. 24, 2016, 3:26 p.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42697/
> -----------------------------------------------------------
>
> (Updated Jan. 24, 2016, 3:26 p.m.)
>
>
> Review request for mesos, Adam B and Joerg Schad.
>
>
> Bugs: MESOS-4340
> https://issues.apache.org/jira/browse/MESOS-4340
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Remove checkpointing field from SlaveInfo after deprecation.
>
>
> Diffs
> -----
>
> docs/slave-recovery.md acf36b9693972641f38a96e8d6b682e02b6cdbb3
> include/mesos/mesos.proto 96b911fb370223933df52f9370897871827d2247
> src/common/type_utils.cpp 76f48f6a1f5467db032ded8acd296d03353b4172
> src/internal/devolve.cpp 27918f1fc385b1770843697c16a29fd0d376f39d
> src/slave/slave.cpp 1f4c8368feb0ce19963577582ce745acfb21aa9f
>
> Diff: https://reviews.apache.org/r/42697/diff/
>
>
> Testing
> -------
>
> make -j8 check
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 42697: Remove checkpointing field from SlaveInfo
after deprecation.
Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42697/#review116018
-----------------------------------------------------------
We planned to wait for this deprecation cycle, any reason to change this right now? The documentation look good nevertheless, so maybe just submit those?
include/mesos/mesos.proto
<https://reviews.apache.org/r/42697/#comment177042>
We planned to wait for this deprecation cycle, any reason to change this right now?
- Joerg Schad
On Jan. 24, 2016, 3:26 p.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42697/
> -----------------------------------------------------------
>
> (Updated Jan. 24, 2016, 3:26 p.m.)
>
>
> Review request for mesos, Adam B and Joerg Schad.
>
>
> Bugs: MESOS-4340
> https://issues.apache.org/jira/browse/MESOS-4340
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Remove checkpointing field from SlaveInfo after deprecation.
>
>
> Diffs
> -----
>
> docs/slave-recovery.md acf36b9693972641f38a96e8d6b682e02b6cdbb3
> include/mesos/mesos.proto 96b911fb370223933df52f9370897871827d2247
> src/common/type_utils.cpp 76f48f6a1f5467db032ded8acd296d03353b4172
> src/internal/devolve.cpp 27918f1fc385b1770843697c16a29fd0d376f39d
> src/slave/slave.cpp 1f4c8368feb0ce19963577582ce745acfb21aa9f
>
> Diff: https://reviews.apache.org/r/42697/diff/
>
>
> Testing
> -------
>
> make -j8 check
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 42697: Remove checkpointing field from SlaveInfo
after deprecation.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42697/
-----------------------------------------------------------
(Updated Jan. 24, 2016, 3:26 p.m.)
Review request for mesos, Adam B and Joerg Schad.
Changes
-------
Update style
Bugs: MESOS-4340
https://issues.apache.org/jira/browse/MESOS-4340
Repository: mesos
Description
-------
Remove checkpointing field from SlaveInfo after deprecation.
Diffs (updated)
-----
docs/slave-recovery.md acf36b9693972641f38a96e8d6b682e02b6cdbb3
include/mesos/mesos.proto 96b911fb370223933df52f9370897871827d2247
src/common/type_utils.cpp 76f48f6a1f5467db032ded8acd296d03353b4172
src/internal/devolve.cpp 27918f1fc385b1770843697c16a29fd0d376f39d
src/slave/slave.cpp 1f4c8368feb0ce19963577582ce745acfb21aa9f
Diff: https://reviews.apache.org/r/42697/diff/
Testing (updated)
-------
make -j8 check
Thanks,
haosdent huang