You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by K0zka <gi...@git.apache.org> on 2015/03/06 17:48:53 UTC
[GitHub] cloudstack pull request: CLOUDSTACK-8304: disable snapshots from n...
GitHub user K0zka opened a pull request:
https://github.com/apache/cloudstack/pull/100
CLOUDSTACK-8304: disable snapshots from non-snapshot repositories
Signed-off-by: Laszlo Hornyak <la...@gmail.com>
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/K0zka/cloudstack CLOUDSTACK-8304
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/100.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #100
----
commit 7121b90c76ef1a3f58ea77f93bad415029903a95
Author: Laszlo Hornyak <la...@gmail.com>
Date: 2015-03-06T16:41:32Z
CLOUDSTACK-8304: disable snapshots from non-snapshot repositories
Signed-off-by: Laszlo Hornyak <la...@gmail.com>
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8304: disable snapshots from n...
Posted by karuturi <gi...@git.apache.org>.
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/100#issuecomment-77817353
I dont think this fixes the issue. we are specifying a version number. maven will not check for snapshots.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8304: disable snapshots from n...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/100#issuecomment-77995743
Not a maven expert, leaving for someone to review/merge who is.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8304: disable snapshots from n...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/100#issuecomment-77811516
LGTM. @K0zka please merge it on both master and 4.5!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8304: disable snapshots from n...
Posted by karuturi <gi...@git.apache.org>.
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/100#issuecomment-78038271
understood. This will definitely save build time. (will do the merge in sometime)
But, the build will fail irrespective of whether snapshot is enabled right? if the server goes offline, we will not get the dependency jar as well(in this case libvirt).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8304: disable snapshots from n...
Posted by K0zka <gi...@git.apache.org>.
Github user K0zka commented on the pull request:
https://github.com/apache/cloudstack/pull/100#issuecomment-78041502
@karuturi Correct, if you do not have the libvirt jar and libvirt.org goes down, the build will still fail. It would be nice if we could use only the central repository, but that will need some work with the ceph and libvirt team.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8304: disable snapshots from n...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/100
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8304: disable snapshots from n...
Posted by K0zka <gi...@git.apache.org>.
Github user K0zka commented on the pull request:
https://github.com/apache/cloudstack/pull/100#issuecomment-78022061
@karuturi So the problem that it adresses is this: We have SNAPSHOT dependencies, since snapshots are not disabled on those repositories, they will be checked. Now the problem is that if one of those servers is not available, that is breaking the build.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---