[GitHub] [jackrabbit-filevault] DominikSuess commented on a change in pull request #136: JCRVLT-517 fix package cache init in OSGi containers

[GitBox <gi...@apache.org>]

DominikSuess commented on a change in pull request #136:
URL: https://github.com/apache/jackrabbit-filevault/pull/136#discussion_r622786889



##########
File path: vault-core/src/main/java/org/apache/jackrabbit/vault/packaging/registry/impl/FSPackageRegistry.java
##########
@@ -185,6 +182,7 @@ public void activate(BundleContext context, Config config) {
         log.info("Jackrabbit Filevault FS Package Registry initialized with home location {}", this.homeDir.getPath());
         this.scope = InstallationScope.valueOf(config.scope());
         this.securityConfig = new AbstractPackageRegistry.SecurityConfig(config.authIdsForHookExecution(), config.authIdsForRootInstallation());
+        loadPackageCache();

Review comment:
       The reason for not loading the cache here is because package operations are no frequent use case while the activate happens at any start of the system. This was designed for a Cloud-Service scenario with frequent starts & stops. Any expensive operation should be cut out of the startup procedure. The non-osgi initialization on the other hand is only required for initialization of an 'immutable' state of this is registry which would then only be read at system runtime (reused state) to validate dependencies for the mutable part being handled by the jcr registry. In case we have new scenarios we should make sure to not sacrifice those performance aspects. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org