You are viewing a plain text version of this content. The canonical link for it is here.
Posted to bugs@httpd.apache.org by bu...@apache.org on 2011/03/18 18:40:07 UTC
DO NOT REPLY [Bug 50946] mod_example using 100% cpu under load
https://issues.apache.org/bugzilla/show_bug.cgi?id=50946
--- Comment #1 from Jeff Trawick <tr...@apache.org> 2011-03-18 13:40:05 EDT ---
quick handler mis-calls trace_add and triggers non-thread-safe code usually run
during init
this probably fixes it
Index: modules/experimental/mod_example.c
===================================================================
--- modules/experimental/mod_example.c (revision 1082598)
+++ modules/experimental/mod_example.c (working copy)
@@ -922,7 +922,7 @@
/*
* Log the call and exit.
*/
- trace_add(r->server, NULL, cfg, "x_http_scheme()");
+ trace_add(r->server, r, cfg, "x_http_scheme()");
return "example";
}
@@ -941,7 +941,7 @@
/*
* Log the call and exit.
*/
- trace_add(r->server, NULL, cfg, "x_default_port()");
+ trace_add(r->server, r, cfg, "x_default_port()");
return 80;
}
#endif /*0*/
@@ -961,7 +961,7 @@
/*
* Log the call and exit.
*/
- trace_add(r->server, NULL, cfg, "x_insert_filter()");
+ trace_add(r->server, r, cfg, "x_insert_filter()");
}
/*
@@ -979,7 +979,7 @@
/*
* Log the call and exit.
*/
- trace_add(r->server, NULL, cfg, "x_quick_handler()");
+ trace_add(r->server, r, cfg, "x_quick_handler()");
return DECLINED;
}
(I presume the submitter doesn't particularly care about mod_example; no need
to test the fix)
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org