[jira] [Work logged] (GOBBLIN-1579) Propagate HiveTableLocationNotMatchException to fail the job execution

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/GOBBLIN-1579?focusedWorklogId=683758&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-683758 ]

ASF GitHub Bot logged work on GOBBLIN-1579:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 19/Nov/21 03:30
            Start Date: 19/Nov/21 03:30
    Worklog Time Spent: 10m 
      Work Description: vgnanasekaran opened a new pull request #3433:
URL: https://github.com/apache/gobblin/pull/3433


   Dear Gobblin maintainers,
   
   Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
   
   
   ### JIRA
   - [ ] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
       - https://issues.apache.org/jira/browse/GOBBLIN-1579
   
   
   ### Description
   - [ ] Here are some details about my PR, including screenshots (if applicable):
   When path of the existing hive table in target does not match with the desired path of the target table to be copied, HiveTableLocationNotMatchException is logged, empty list is returned and job state is set to committed. Propagating the HiveTableLocationNotMatchException so that job state can be set as failed.
   
   ### Tests
   - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   UnpartitionedTableFileSetTest.java
   
   ### Commits
   - [ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
       1. Subject is separated from body by a blank line
       2. Subject is limited to 50 characters
       3. Subject does not end with a period
       4. Subject uses the imperative mood ("add", not "adding")
       5. Body wraps at 72 characters
       6. Body explains "what" and "why", not "how"
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 683758)
    Remaining Estimate: 0h
            Time Spent: 10m

> Propagate HiveTableLocationNotMatchException to fail the job execution
> ----------------------------------------------------------------------
>
>                 Key: GOBBLIN-1579
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1579
>             Project: Apache Gobblin
>          Issue Type: Bug
>            Reporter: Venkatesh
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> When existing target table path is different from desired path for an hive data movement  the below mentioned code in UnpartitionedTableFileSet class gets executed. 
> default:
>   log.error("Source and target table are not compatible. Aborting copy of table " + this.helper.getTargetTable(),
>       new HiveTableLocationNotMatchException(this.helper.getTargetTable().getDataLocation(),
>           existingTargetTable.get().getDataLocation()));
>   multiTimer.close();
>   return Lists.newArrayList();
> HiveTableLocationNotMatchException is just logged as an Error and empty list is returned. Though the workunits computation failed, because of the empty arraylist, the created workunits is zero and the job status is set as COMMITTED.
>  
> Error log:
> 2021-11-16 11:37:04 PST ERROR [request-allocator-0] org.apache.gobblin.data.management.copy.hive.UnpartitionedTableFileSet  - Source and target table are not compatible. Aborting copy of table employeeorg.apache.gobblin.data.management.copy.hive.HiveTableLocationNotMatchException: Desired target location [hdfs://localhost:8020/tmp/hive/tc_db_1_copy/employee] and already registered target location file:/tmp/hive/tc_db_copy/employee/data/employee do not agree.         at org.apache.gobblin.data.management.copy.hive.UnpartitionedTableFileSet.generateCopyEntities(UnpartitionedTableFileSet.java:86)
>  
> Solution:
> Throw HiveTableLocationNotMatchException so that the exception will be propogated to the caller and the job run will result in failure.
>  



--
This message was sent by Atlassian Jira
(v8.20.1#820001)