You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/08/25 01:29:05 UTC

[GitHub] [spark] cloud-fan commented on pull request #37649: [SPARK-40209][SQL] Don't change the interval value of Decimal in `changePrecision()` on errors

cloud-fan commented on PR #37649:
URL: https://github.com/apache/spark/pull/37649#issuecomment-1226667234

   > This change seems to break the design.
   
   I don't think so. Having side effects for better performance is OK, but it doesn't mean we can leave the decimal value in a "crashed" state. `changePrecision` should be a no-op if it returns false.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org