[GitHub] [pulsar] merlimat commented on a diff in pull request #19432: [improve] Allow to build and push multi-arch Docker images

["merlimat (via GitHub)" <gi...@apache.org>]

merlimat commented on code in PR #19432:
URL: https://github.com/apache/pulsar/pull/19432#discussion_r1127109356


##########
docker/pulsar-all/pom.xml:
##########
@@ -161,5 +169,29 @@
         </plugins>
       </build>
     </profile>
+
+    <profile>
+      <id>docker-push</id>

Review Comment:
   The point here is that we need a profile that does build the multi-arch when doing a release. 
   
   It's also important that the build & push are done in one step so that buildx can push a single tag with 2 separate images.
   
   Yes, the release process would need to be adjust a little bit.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org