You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/02/08 12:52:02 UTC

[GitHub] [apisix] Yiyiyimu opened a new issue #3560: bug: test case not stable: t/plugin/tcp-logger.t

Yiyiyimu opened a new issue #3560:
URL: https://github.com/apache/apisix/issues/3560


   ### Issue description
   
   Test failed in CI and rerun succeeds, but the error seems could not be reproduced on my side.
   ```
   #   Failed test 'TEST 7: check plugin configuration updating - status code ok'
   #   at /home/runner/work/apisix/apisix/test-nginx/lib/Test/Nginx/Socket.pm line 948.
   #          got: '404'
   #     expected: '200'
   
   #   Failed test 'TEST 7: check plugin configuration updating - response_body - response is expected (repeated req 0, req 0)'
   #   at /home/runner/work/apisix/apisix/test-nginx/lib/Test/Nginx/Socket.pm line 1589.
   # @@ -1,2 +1 @@
   # -passedopentracing
   # +fail
   # -passedopentracing
   
   #   Failed test 'TEST 7: check plugin configuration updating - grep_error_log_out (req 0)'
   #   at /home/runner/work/apisix/apisix/test-nginx/lib/Test/Nginx/Socket.pm line 1149.
   # @@ -1,2 +0,0 @@
   # -sending a batch logs to 127.0.0.1:5044
   # -sending a batch logs to 127.0.0.1:5045
   # Looks like you failed 3 tests of 21.
   t/plugin/tcp-logger.t ...................... 
   Dubious, test returned 3 (wstat 768, 0x300)
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] Yiyiyimu commented on issue #3560: bug: test case not stable: t/plugin/tcp-logger.t

Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on issue #3560:
URL: https://github.com/apache/apisix/issues/3560#issuecomment-775597755


   Thanks @spacewander good to know that!
   
   BTW, which aspect of chaos test do you think would be helpful to this issue


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] spacewander closed issue #3560: bug: test case not stable: t/plugin/tcp-logger.t

Posted by GitBox <gi...@apache.org>.
spacewander closed issue #3560:
URL: https://github.com/apache/apisix/issues/3560


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] spacewander commented on issue #3560: bug: test case not stable: t/plugin/tcp-logger.t

Posted by GitBox <gi...@apache.org>.
spacewander commented on issue #3560:
URL: https://github.com/apache/apisix/issues/3560#issuecomment-775580270


   See https://github.com/apache/apisix/issues/3450


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] Yiyiyimu commented on issue #3560: bug: test case not stable: t/plugin/tcp-logger.t

Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on issue #3560:
URL: https://github.com/apache/apisix/issues/3560#issuecomment-775620998


   > This is a known issue. We plan to start pulling etcd data in the `init_worker` phase. To achieve this, we need to implement two preconditions first:
   > 
   > 1. add Chaos test so that we can cover such a big change
   > 2. allow lua-resty-etcd to use luasocket.
   > 
   > Maybe we can do this in version `2.5`.
   
   I mean you talked about using chaos test to better cover the critical change, is there any specific test do you think would be of help?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] spacewander commented on issue #3560: bug: test case not stable: t/plugin/tcp-logger.t

Posted by GitBox <gi...@apache.org>.
spacewander commented on issue #3560:
URL: https://github.com/apache/apisix/issues/3560#issuecomment-775611782


   It is obvious. And people have complained about it since last year. The problem is that we don't have enough resource to solve it early.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org