You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/10/26 07:45:41 UTC
[GitHub] [airflow] NickYadance opened a new pull request, #27289: Add retry to submit_event in trigger to avoid deadlock
NickYadance opened a new pull request, #27289:
URL: https://github.com/apache/airflow/pull/27289
related: #27000
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ephraimbuddy commented on a diff in pull request #27289: Add retry to submit_event in trigger to avoid deadlock
Posted by GitBox <gi...@apache.org>.
ephraimbuddy commented on code in PR #27289:
URL: https://github.com/apache/airflow/pull/27289#discussion_r1007843469
##########
airflow/models/trigger.py:
##########
@@ -116,7 +116,7 @@ def clean_unused(cls, session=None):
session.query(Trigger).filter(Trigger.id.in_(ids)).delete(synchronize_session=False)
@classmethod
- @provide_session
Review Comment:
I think the session arg should no longer be equal to None
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] NickYadance commented on a diff in pull request #27289: Add retry to submit_event in trigger to avoid deadlock
Posted by GitBox <gi...@apache.org>.
NickYadance commented on code in PR #27289:
URL: https://github.com/apache/airflow/pull/27289#discussion_r1007865848
##########
airflow/models/trigger.py:
##########
@@ -116,7 +116,7 @@ def clean_unused(cls, session=None):
session.query(Trigger).filter(Trigger.id.in_(ids)).delete(synchronize_session=False)
@classmethod
- @provide_session
Review Comment:
> I think the session arg should no longer be equal to None
yea right, replaced with run_with_db_retries.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a diff in pull request #27289: Add retry to submit_event in trigger to avoid deadlock
Posted by GitBox <gi...@apache.org>.
uranusjr commented on code in PR #27289:
URL: https://github.com/apache/airflow/pull/27289#discussion_r1007822157
##########
airflow/models/trigger.py:
##########
@@ -116,7 +116,7 @@ def clean_unused(cls, session=None):
session.query(Trigger).filter(Trigger.id.in_(ids)).delete(synchronize_session=False)
@classmethod
- @provide_session
Review Comment:
I think you still need this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] NickYadance commented on pull request #27289: Add retry to submit_event in trigger to avoid deadlock
Posted by GitBox <gi...@apache.org>.
NickYadance commented on PR #27289:
URL: https://github.com/apache/airflow/pull/27289#issuecomment-1294825161
close this one as i misconfigured git
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] NickYadance closed pull request #27289: Add retry to submit_event in trigger to avoid deadlock
Posted by GitBox <gi...@apache.org>.
NickYadance closed pull request #27289: Add retry to submit_event in trigger to avoid deadlock
URL: https://github.com/apache/airflow/pull/27289
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ephraimbuddy commented on a diff in pull request #27289: Add retry to submit_event in trigger to avoid deadlock
Posted by GitBox <gi...@apache.org>.
ephraimbuddy commented on code in PR #27289:
URL: https://github.com/apache/airflow/pull/27289#discussion_r1007843120
##########
airflow/models/trigger.py:
##########
@@ -116,7 +116,7 @@ def clean_unused(cls, session=None):
session.query(Trigger).filter(Trigger.id.in_(ids)).delete(synchronize_session=False)
@classmethod
- @provide_session
Review Comment:
I think the session arg should no longer be equal to None
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] NickYadance commented on a diff in pull request #27289: Add retry to submit_event in trigger to avoid deadlock
Posted by GitBox <gi...@apache.org>.
NickYadance commented on code in PR #27289:
URL: https://github.com/apache/airflow/pull/27289#discussion_r1007833530
##########
airflow/models/trigger.py:
##########
@@ -116,7 +116,7 @@ def clean_unused(cls, session=None):
session.query(Trigger).filter(Trigger.id.in_(ids)).delete(synchronize_session=False)
@classmethod
- @provide_session
Review Comment:
https://github.com/apache/airflow/blob/4797a0322ed4b73bc34d3967376479a42d9ba190/airflow/utils/retries.py#L49-L53
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ephraimbuddy commented on a diff in pull request #27289: Add retry to submit_event in trigger to avoid deadlock
Posted by GitBox <gi...@apache.org>.
ephraimbuddy commented on code in PR #27289:
URL: https://github.com/apache/airflow/pull/27289#discussion_r1007842360
##########
airflow/models/trigger.py:
##########
@@ -116,7 +116,7 @@ def clean_unused(cls, session=None):
session.query(Trigger).filter(Trigger.id.in_(ids)).delete(synchronize_session=False)
@classmethod
- @provide_session
Review Comment:
I think the session arg should no longer be equal to None
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ephraimbuddy commented on a diff in pull request #27289: Add retry to submit_event in trigger to avoid deadlock
Posted by GitBox <gi...@apache.org>.
ephraimbuddy commented on code in PR #27289:
URL: https://github.com/apache/airflow/pull/27289#discussion_r1007842360
##########
airflow/models/trigger.py:
##########
@@ -116,7 +116,7 @@ def clean_unused(cls, session=None):
session.query(Trigger).filter(Trigger.id.in_(ids)).delete(synchronize_session=False)
@classmethod
- @provide_session
Review Comment:
I think the session arg should no longer be equal to None
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org