You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2017/08/02 00:54:07 UTC
Review Request 61286: Added `stout` interface library.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61286/
-----------------------------------------------------------
Review request for mesos.
Repository: mesos
Description
-------
CMake provides a mechanism for dealing with header only libraries such
as `stout`: an interface library. Thus CMake will treat `stout` as a
"library" and automatically add the necessary compiler and link
information to targets which depend on `stout`.
Diffs
-----
3rdparty/stout/CMakeLists.txt PRE-CREATION
3rdparty/stout/cmake/StoutConfigure.cmake 69474a830e3cbd2e3e2718e4a7569137fc6df6b8
3rdparty/stout/cmake/StoutTestsConfigure.cmake 43baaca784063773fdd700365cadb3532e5c6b3f
3rdparty/stout/tests/CMakeLists.txt 953be64f1fb675fd1166fa77d0b3a56a5763d243
Diff: https://reviews.apache.org/r/61286/diff/1/
Testing
-------
Thanks,
Andrew Schwartzmeyer
Re: Review Request 61286: Added `stout` interface library.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61286/#review182349
-----------------------------------------------------------
Ship it!
[Tentative "Ship It!" as I review this entire chain.]
- Joseph Wu
On Aug. 1, 2017, 5:54 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61286/
> -----------------------------------------------------------
>
> (Updated Aug. 1, 2017, 5:54 p.m.)
>
>
> Review request for mesos and Joseph Wu.
>
>
> Bugs: MESOS-7811
> https://issues.apache.org/jira/browse/MESOS-7811
>
>
> Repository: mesos
>
>
> Description
> -------
>
> CMake provides a mechanism for dealing with header only libraries such
> as `stout`: an interface library. Thus CMake will treat `stout` as a
> "library" and automatically add the necessary compiler and link
> information to targets which depend on `stout`.
>
>
> Diffs
> -----
>
> 3rdparty/stout/CMakeLists.txt PRE-CREATION
> 3rdparty/stout/cmake/StoutConfigure.cmake 69474a830e3cbd2e3e2718e4a7569137fc6df6b8
> 3rdparty/stout/cmake/StoutTestsConfigure.cmake 43baaca784063773fdd700365cadb3532e5c6b3f
> 3rdparty/stout/tests/CMakeLists.txt 953be64f1fb675fd1166fa77d0b3a56a5763d243
>
>
> Diff: https://reviews.apache.org/r/61286/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>