You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by xiaojian zhou <zh...@gmail.com> on 2016/03/03 02:19:16 UTC
Review Request 44306: shadowPR's entries do not have version tag
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44306/
-----------------------------------------------------------
Review request for geode and Dan Smith.
Bugs: GEODE-1042
https://issues.apache.org/jira/browse/GEODE-1042
Repository: geode
Description
-------
shadowPR's entries do not have version tag, FetchEntriesMessage should check the versionTag==null in processChunk.
Diffs
-----
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/FetchEntriesMessage.java 0342164
Diff: https://reviews.apache.org/r/44306/diff/
Testing
-------
precheckin
the failed test itself
Thanks,
xiaojian zhou
Re: Review Request 44306: shadowPR's entries do not have version tag
Posted by Dan Smith <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44306/#review121772
-----------------------------------------------------------
Also, can you add a test for this?
- Dan Smith
On March 3, 2016, 1:19 a.m., xiaojian zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44306/
> -----------------------------------------------------------
>
> (Updated March 3, 2016, 1:19 a.m.)
>
>
> Review request for geode and Dan Smith.
>
>
> Bugs: GEODE-1042
> https://issues.apache.org/jira/browse/GEODE-1042
>
>
> Repository: geode
>
>
> Description
> -------
>
> shadowPR's entries do not have version tag, FetchEntriesMessage should check the versionTag==null in processChunk.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/FetchEntriesMessage.java 0342164
>
> Diff: https://reviews.apache.org/r/44306/diff/
>
>
> Testing
> -------
>
> precheckin
> the failed test itself
>
>
> Thanks,
>
> xiaojian zhou
>
>
Re: Review Request 44306: shadowPR's entries do not have version tag
Posted by Dan Smith <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44306/#review121771
-----------------------------------------------------------
Ship it!
Minor point - can you fix the code formatting (add some spaces):
versionTag == null ? null : versionTag.getMemberID();
- Dan Smith
On March 3, 2016, 1:19 a.m., xiaojian zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44306/
> -----------------------------------------------------------
>
> (Updated March 3, 2016, 1:19 a.m.)
>
>
> Review request for geode and Dan Smith.
>
>
> Bugs: GEODE-1042
> https://issues.apache.org/jira/browse/GEODE-1042
>
>
> Repository: geode
>
>
> Description
> -------
>
> shadowPR's entries do not have version tag, FetchEntriesMessage should check the versionTag==null in processChunk.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/FetchEntriesMessage.java 0342164
>
> Diff: https://reviews.apache.org/r/44306/diff/
>
>
> Testing
> -------
>
> precheckin
> the failed test itself
>
>
> Thanks,
>
> xiaojian zhou
>
>