You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2018/01/04 17:06:17 UTC

[GitHub] eiri opened a new pull request #1092: Use uuid in tmp db names in unit tests

eiri opened a new pull request #1092: Use uuid in tmp db names in unit tests
URL: https://github.com/apache/couchdb/pull/1092
 
 
   ## Overview
   
   This changes naming of temporary eunit databases and files from using unique_monotonic_integer to couch_uuids:random to remove performance penalty and normalize naming across erlang releases.
   
   Also getting rid of unnecessary inter-types convertion.
   
   ## Testing recommendations
   
   `make eunit` should come clean. Files in `$PWD/tmp` should be named like `tmp/data/eunit-test-db-a6a4cd31f2addf2791440b3e8b54f860.1515084353.couch` or `tmp/tmp_data/nonode@nohost-018448e4ebb1f85812fd96d56939a620`
   
   ## Checklist
   
   - [x] Code is written and works correctly;
   - [x] Changes are covered by tests;
   - [ ] Documentation reflects the changes;
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services