[GitHub] dubeejw commented on a change in pull request #2218: Port Controller from Spray to Akka (WIP!!!)

[gi...@git.apache.org]

dubeejw commented on a change in pull request #2218: Port Controller from Spray to Akka (WIP!!!)
URL: https://github.com/apache/incubator-openwhisk/pull/2218#discussion_r123822898
 
 

 ##########
 File path: core/controller/src/main/scala/whisk/core/controller/API.scala
 ##########
 @@ -77,16 +77,16 @@ protected[controller] class SwaggerDocs(apipath: Uri.Path, doc: String)(implicit
 }
 
 protected[controller] object RestApiCommons {
-    def requiredProperties =
-        WhiskConfig.whiskVersion ++
-                WhiskAuthStore.requiredProperties ++
-                WhiskEntityStore.requiredProperties ++
-                WhiskActivationStore.requiredProperties ++
-                WhiskConfig.consulServer ++
-                EntitlementProvider.requiredProperties ++
-                WhiskActionsApi.requiredProperties ++
-                Authenticate.requiredProperties ++
-                Collection.requiredProperties
+    def requiredProperties = Map(WhiskConfig.servicePort -> 8080.toString) ++
 
 Review comment:
   Service port should be configurable in Ansible.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services