You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "igarashitm (via GitHub)" <gi...@apache.org> on 2023/08/30 16:37:06 UTC

[GitHub] [camel] igarashitm opened a new pull request, #11244: [CAMEL-19698] [CAMEL-19699] camel-yaml-dsl: schema: Restrict language…

igarashitm opened a new pull request, #11244:
URL: https://github.com/apache/camel/pull/11244

   …s/dataformats to be mutually exclusive
   
   * Added `oneOf` property on @YamlProperty annotation. This is to hold an oneOf grouping name to show those are mutually exclusive on deserializer annotation
   * Let schema generator use the `oneOf` to express mutually exclusiveness using schema composition
   * Redeclare the properties inherited through schema composition. This is required when additionalProperties is set to false
   
   # Target
   
   - [x] I checked that the commit is targeting the correct branch (note that Camel 3 uses `camel-3.x`, whereas Camel 4 uses the `main` branch)
   
   # Tracking
   - [x] If this is a large change, bug fix, or code improvement, I checked there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it).
   * https://issues.apache.org/jira/browse/CAMEL-19698
   * https://issues.apache.org/jira/browse/CAMEL-19699
   
   
   # Apache Camel coding standards and style
   
   - [x] I checked that each commit in the pull request has a meaningful subject line and body.
   
   
   - [x] I have run `mvn clean install -DskipTests` locally and I have committed all auto-generated changes
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel] github-actions[bot] commented on pull request #11244: [CAMEL-19698] [CAMEL-19699] camel-yaml-dsl: schema: Restrict language…

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #11244:
URL: https://github.com/apache/camel/pull/11244#issuecomment-1699482069

   :star2: Thank you for your contribution to the Apache Camel project! :star2: 
   
   :camel: Maintainers, please note that first-time contributors *require manual approval* for the GitHub Actions to run.
   
   :warning: Please note that the changes on this PR may be **tested automatically** if they change components.
   
   :robot: Use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot.
   
   If necessary Apache Camel Committers may access logs and test results in the job summaries!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel] igarashitm commented on pull request #11244: [CAMEL-19698] [CAMEL-19699] camel-yaml-dsl: schema: Restrict language…

Posted by "igarashitm (via GitHub)" <gi...@apache.org>.
igarashitm commented on PR #11244:
URL: https://github.com/apache/camel/pull/11244#issuecomment-1699486793

   Tested with vscode-yaml plugin, got expected validation errors
   ![vscode-validation](https://github.com/apache/camel/assets/265462/ad9de6c7-ea22-49bb-ac41-c38b5ab92549)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel] igarashitm merged pull request #11244: [CAMEL-19698] [CAMEL-19699] camel-yaml-dsl: schema: Restrict language…

Posted by "igarashitm (via GitHub)" <gi...@apache.org>.
igarashitm merged PR #11244:
URL: https://github.com/apache/camel/pull/11244


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org