[GitHub] [kafka] dengziming commented on a change in pull request #11173: MINOR: Support max timestamp in GetOffsetShell

[GitBox <gi...@apache.org>]

dengziming commented on a change in pull request #11173:
URL: https://github.com/apache/kafka/pull/11173#discussion_r762572434



##########
File path: core/src/main/scala/kafka/tools/GetOffsetShell.scala
##########
@@ -195,16 +205,24 @@ object GetOffsetShell {
         val upperRange = group(4).map(_.toInt).getOrElse(Int.MaxValue)
         (p: Int) => p >= lowerRange && p < upperRange
     }
-
-    tp => topicFilter.isTopicAllowed(tp.topic, excludeInternalTopics) && partitionFilter(tp.partition)
+    (
+      topic => topicFilter.isTopicAllowed(topic, excludeInternalTopics),
+      tp => topicFilter.isTopicAllowed(tp.topic, excludeInternalTopics) && partitionFilter(tp.partition)
+    )

Review comment:
       Thank you for this suggestion, I reused the existing `IncludeList` and added a new `PartitionFilter` to simplify this, more suggestions are welcomed.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org